feat(go): add nfs_provision and cifs_provision programs#58
Open
mahatvagarg wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Go implementations for the existing nfs-provision and cifs-provision use cases, bringing Go parity alongside the repository’s other language variants and wiring the new examples into the central example catalog.
Changes:
- Introduces
go/nfs_provisionto provision a FlexVol plus NFS export policy and client rule in an idempotent workflow. - Introduces
go/cifs_provisionto provision an NTFS-style FlexVol plus CIFS share and ACL, with optional workgroup CIFS server creation. - Extends
catalog.yamlto register the new Go variants for both use cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| go/nfs_provision/main.go | New Go program implementing NFS volume + export policy provisioning workflow |
| go/cifs_provision/main.go | New Go program implementing CIFS volume + share + ACL provisioning workflow |
| catalog.yaml | Adds go variants for nfs-provision and cifs-provision use cases |
Comment on lines
+45
to
+49
| "context" | ||
| "errors" | ||
| "fmt" | ||
| "log" | ||
| "time" |
Comment on lines
+222
to
+223
| sharePath := fmt.Sprintf("%s/%s/%s", pathCIFSShares, svmUUID, shareName) | ||
| _, err := client.Get(ctx, sharePath, map[string]string{"fields": "name"}) |
Comment on lines
+248
to
+249
| aclPath := fmt.Sprintf("%s/%s/%s/acls/%s/windows", pathCIFSShares, svmUUID, shareName, user) | ||
| log.Printf("Setting ACL: %s → %s on share '%s'…", user, permission, shareName) |
Comment on lines
+259
to
+260
| sharePath := fmt.Sprintf("%s/%s/%s", pathCIFSShares, svmUUID, shareName) | ||
| resp, err := client.Get(ctx, sharePath, map[string]string{"fields": "name,path,acls"}) |
hvinn
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go implementations of
nfs-provisionandcifs-provision, completingfour-language coverage for both use cases.
Changes
go/nfs_provision/main.go— new: create FlexVol + NFS export policy + client-match rule; 6-step idempotent workflowgo/cifs_provision/main.go— new: create NTFS FlexVol + CIFS share + ACL; optional workgroup CIFS server creation; 8-step idempotent workflowcatalog.yaml— addedgovariant tonfs-provisionandcifs-provisionuse casesChecklist
General
catalog.yamland tool README for new/changed examples (see CONTRIBUTING.md)If touching
go/go vet ./...passes (fromgo/directory)go build -o /dev/null .passes for both new programsTest Report
Environment: ONTAP Simulator (vSIM), Go 1.26.4, Windows 11
Platform version: ONTAP 9.14.1 onwards
Style touched: go
Ran both scripts against a vSIM. Volumes, export policy, CIFS share, and ACL
were created on first run. Re-running both scripts a second time skipped all
already-existing resources without errors.
Related issues