Revert to using miekg/dns functionality for serveUDP and serveTCP ins… - #42
Open
sbocconi wants to merge 1 commit into
Open
Revert to using miekg/dns functionality for serveUDP and serveTCP ins…#42sbocconi wants to merge 1 commit into
sbocconi wants to merge 1 commit into
Conversation
…tead of custom code
adam-burns
force-pushed
the
correct_udp_tcp
branch
from
September 3, 2026 13:45
64a62d3 to
c614f6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use miekg/dns functionality to serve UDP and TCP requests.
Due to a misunderstanding previous versions of the proxy had custom code to handle TCP and UDP requests.
The issue is that miekg/dns serveDNS only unpacks the Question section and leaves further unpacking to the handler, as also described in the comment to the Handler interface.
This was preventing the proxy's handler to recognise the packet as an UPDATE LEASE, as it was expecting an unpacked msg.
Now the handler is wrapped to receive an unpacked message.