fix(ui): restore the active project before session hydration - #707
Merged
Merged
Conversation
Select the saved project as soon as its restored workspace tab is bound. Previously selection depended on conversation hydration finishing and settling the preserved tab, so slow requests or a competing capture settlement could leave the wrong project active. Keep the restored binding check and selection revision guard so a manual project choice during startup remains authoritative. Conversation hydration continues independently of project selection. Add a browser fixture exercising the real restore and capture hooks with delayed conversation requests for Electron and Tauri. Cover selection before hydration, persistence afterward, and user selection during restoration. Validated four browser cases, 27 targeted store tests, UI typecheck, and production UI build.
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/35321898454 Artifacts expire in 7 days.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the saved active project as soon as its workspace tab is bound, without waiting for conversation hydration.
Previously selection happened only after conversation hydration and a successful preservation settlement. Slow session requests delayed project selection; a competing settlement from the capture hook could also bypass it. The saved project could therefore remain unselected despite its tab already existing.
The selection now uses the restored binding and the existing user-selection revision guard. A manual project choice during startup remains authoritative.
Validation
Local delivery
Updated the installed application's UI assets for the next launch. No native binary rebuild or real-profile restart was performed for this fix; runtime validation is through isolated browser fixtures.