Skip to content

fix(site): resolve 404 for favicon.ico and configure Eleventy passthrough #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbampton merged 7 commits into from
Nov 6, 2026
Merged

fix(site): resolve 404 for favicon.ico and configure Eleventy passthrough #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3647d79
fix(site): resolve 404 for favicon.ico and configure passthrough copy
koushik4475 Oct 17, 2026
1abfa32
Merge branch 'main' into fix/issue-134-favicon
jbampton Oct 17, 2026
74f63eb
fix(assets): replace JPEG assets with genuine ICO format favicons
koushik4475 Oct 18, 2026
ecc7968
Merge branch 'main' into fix/issue-134-favicon
jbampton Oct 24, 2026
80827da
Merge branch 'main' into fix/issue-134-favicon
jbampton Oct 26, 2026
98b016f
Merge branch 'main' into fix/issue-134-favicon
BaseMax Oct 26, 2026
5e78384
Merge branch 'main' into fix/issue-134-favicon
jbampton Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eleventy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module.exports = (eleventyConfig) => {
});
// Add this line to copy your external assets
eleventyConfig.addPassthroughCopy("src/assets");
eleventyConfig.addPassthroughCopy({ "src/favicon.ico": "favicon.ico" });
Comment thread
jbampton marked this conversation as resolved.
Resolved
// 1. Recognize YAML as a template format
eleventyConfig.addTemplateFormats("yaml");

Expand Down
2 changes: 2 additions & 0 deletions src/_includes/layouts/base.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
{% include "seo-meta.njk" %}
<link rel="stylesheet" href="/assets/css/tailwind.css">
<link rel="stylesheet" href="/assets/css/style.css">
<link rel="icon" type="image/x-icon" href="/favicon.ico">
<link rel="shortcut icon" href="/favicon.ico">
</head>
<body class="min-h-screen scroll-smooth bg-[var(--bg-page)] text-[var(--text-main)] transition-colors duration-300">

Expand Down
Binary file added src/assets/img/favicon.ico
View file
Open in desktop
Binary file not shown.
Binary file added src/favicon.ico
View file
Open in desktop
Binary file not shown.
Loading