Stop a property name shadowing the codec's argument - #17
Merged
Merged
Conversation
`to_wire` read each property into a local named after it, so a document with a property called `value` emitted `value = value.value`, rebinding the struct the method was given. Every property after it then read off an Optional and raised NoMethodError. A property called `wire` clobbered the accumulator the same way. The locals are fixed names now, so no property can reach them.
Jack97
force-pushed
the
jr/codec-argument-shadowing
branch
from
September 14, 2026 15:28
f35517a to
a944060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A document with a property named
valuegeneratedvalue = value.valueinsideto_wire, rebinding the struct the method was given — every property after it then raisedNoMethodError. A property namedwireclobbered the accumulator hash.Found in nexus-api's
MonthlyReportEntry, whichnextconsumes.The locals are fixed names now. The adversarial fixture grew
value,wire,innerand a trailing property so the golden tree locks it in.