Repository navigation
Conversation
…e viewport on narrow screens
Owner
|
Thanks for the pull request. We're resetting the tracker for 0.2.0-beta. There are more than 1,300 open issues and pull requests, too many for us to review properly, so we're closing everything that isn't being worked on right now. Closed here does not mean rejected. To reopen it takes about two minutes:
The rules are in CONTRIBUTING.md. |
Author
|
/reopen |
|
The check passed, but GitHub would not reopen it (Validation Failed: ). If the branch was deleted, restore it or open a new pull request and link this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Area: [GUI]
Problem and result
On a narrow screen (phone), an assistant reply containing one long unbroken string (URL, code line) or a wide table stretches the chat column past the viewport: the right side is clipped and unreachable, and the page heading and composer shift with it. After the change the assistant text breaks long strings, wide tables scroll inside their own bubble, and the column stays at viewport width.
Related discussion
none
Approach
serve/web/app.cssonly, two rules:.st-msg--assistant .st-bubble { width: 100%; overflow-wrap: anywhere; }— the assistant bubble now breaks long unbroken strings, matching the user bubble, which already carriedoverflow-wrap: anywhere..st-bubble table { … display: block; max-width: 100%; overflow-x: auto; }— wide tables scroll horizontally inside their bubble instead of widening the column.The
.view { min-width: 0 }guard from the original revision is already present onmain(line 7 of this file), so this revision no longer touches it. Desktop layout is unchanged.Validation
Passed: measured at a 390×844 viewport against 0.1.44.1 with three messages (long URL / long code line / wide table): before — chat column 752 px, bubbles 718 px, right edge 346 px off-screen; after — column 390 px, bubbles 356 px, everything on screen (the URL wraps, the code block and the table scroll inside themselves). Desktop at 1280 px: no overflow before or after, normal prose unaffected.
Failed: none observed.
Not run: not re-measured on 0.2.0-beta — the rebase re-applied the two rules onto current
main, where the CSS they touch is unchanged; the measurements above are from the original 0.1.44.1 revision. No browser engine other than Chromium was tested.Limits
Firefox and Safari not tested.
overflow-wrap: anywherepermits mid-word breaks in assistant prose — accepted trade-off, and already the behaviour of user bubbles.