#4246 proposed changes + task extras - #4353
Merged
Merged
Conversation
wavehassman
marked this pull request as ready for review
July 25, 2026 23:52
wavehassman
changed the title
Santiordon
requested changes
Jul 27, 2026
Santiordon
left a comment
Santiordon
left a comment
Contributor
There was a problem hiding this comment.
Looking great so far!
| ? parent.managerId | ||
| : pickDifferentActor( | ||
| faker, | ||
| ownerCandidates, |
Contributor
There was a problem hiding this comment.
This looks strange to me. Is this intentional? We are using ownerCandidates for both lead and manager even though they are different roles. Also, we are not guarding a case where both the lead and manager for the PC is the same.
Contributor
Author
There was a problem hiding this comment.
The ownerCandidates-for-both-fields part is intentional because the real service functions (createActivationChangeRequest/createLeadershipChangeRequest) don't distinguish lead vs. manager eligibility by role.
Making the guard rn!
Steph375
previously approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4246