Skip to content

[fix][ci] Format Tinker engine test - #2002

Closed
bvolpato wants to merge 1 commit into
NovaSky-AI:mainfrom
bvolpato:bvolpato/format-tinker-test
Closed

[fix][ci] Format Tinker engine test#2002
bvolpato wants to merge 1 commit into
NovaSky-AI:mainfrom
bvolpato:bvolpato/format-tinker-test

Conversation

@bvolpato

@bvolpato bvolpato commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Status

Superseded by #2014, which merged the same Black formatting fix into main.

@bvolpato
bvolpato marked this pull request as ready for review August 7, 2026 01:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces minor formatting adjustments in tests/tinker/test_engine.py by adding blank lines before the forward_backward_payload function. There are no review comments, and I have no feedback to provide.

@bvolpato

Copy link
Copy Markdown
Contributor Author

this is now blocking code-quality checks on #1998 and the newer drafts (#2005, #2006, #2007, and #2010). The patch is formatting-only, and its local pre-commit and focused test validation are green. Could we land it so those branches can rerun against formatted main?

@bvolpato

Copy link
Copy Markdown
Contributor Author

Superseded by #2014, which merged the same Black formatting fix into main.

@bvolpato bvolpato closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant