Repository navigation
fix(messages): extract text from legacy attachments/blocks when content is empty - #18
Open
nulligence wants to merge 2 commits into
Open
nulligence wants to merge 2 commits into
nulligence wants to merge 2 commits into
Conversation
…is empty Bot integrations that post via legacy Slack "attachments" or top-level Block Kit "blocks" (Grafana alerts, threat-investigation bots, etc.) often never populate the plain "text" field. parseRawMessage only ever read raw["text"], so message list/get returned an empty content string for these posts even though the full alert/body was present in attachments[].text/.fallback/.title/.fields or blocks[].text.text — forcing a manual curl fallback against conversations.history to recover the content. Fall back to extracting human-readable text from attachments (including attachments that carry nested Block Kit content instead of legacy fields) and then from top-level blocks, only when "text" is empty, so normal messages are unaffected.
Member
|
Keep open for merge preparation: main still returns empty content for attachment-only and Block Kit-only messages.
|
Member
Pushed fix: 33fb919. Focused remote Go/rule checks remain pending. The description records the current confidence and merge/activation risks; remaining current-base integration and required checks still apply. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attachment-only and Block Kit-only Slack messages returned empty CLI content.
Focused Slack message rendering package with race detection passed on office server 2 at 33fb919.
Correctness confidence: 85% from source inspection; focused remote Go checks passed. Merge risk: low for the rendering fallback; deployment risk is limited to messages previously rendered empty. The repository’s require-labels check passed with the required patch label.