Skip to content

[FIX] document_page_tag: convert create to api.model_create_multi#613

Open
miquelrosell99 wants to merge 1 commit into
OCA:17.0from
miquelrosell99:17.0-fix-document-page-tag-model-create-multi
Open

[FIX] document_page_tag: convert create to api.model_create_multi#613
miquelrosell99 wants to merge 1 commit into
OCA:17.0from
miquelrosell99:17.0-fix-document-page-tag-model-create-multi

Conversation

@miquelrosell99

Copy link
Copy Markdown

Odoo 17 recommends batch-compatible create methods for better performance when creating records in bulk.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:document_page_reference Module document_page_reference series:17.0 mod:document_page_tag Module document_page_tag labels May 20, 2026
@miquelrosell99 miquelrosell99 force-pushed the 17.0-fix-document-page-tag-model-create-multi branch from 674e802 to 71fa48f Compare May 27, 2026 10:05
"""Should raise if reference does not match the required pattern."""
with self.assertRaises(ValidationError):
self.page2.write({"reference": self.page2.reference + "-02"})
self.page2.write({"reference": self.page2.reference + "@02"})

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't be here?

@miquelrosell99 miquelrosell99 force-pushed the 17.0-fix-document-page-tag-model-create-multi branch from 71fa48f to 9560e9f Compare June 30, 2026 06:35
@OCA-git-bot OCA-git-bot removed the mod:document_page_reference Module document_page_reference label Jun 30, 2026
@miquelrosell99

Copy link
Copy Markdown
Author

Hi @etobella, thanks for spotting that.

The change to document_page_reference/tests/test_document_reference.py was unrelated to this PR (it came from a separate experiment to allow dashes in references). I have rebased the branch on 17.0 and removed that commit, so the PR now only contains the document_page_tag api.model_create_multi conversion.

Please re-review when you have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:document_page_tag Module document_page_tag series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants