[FIX] queue_job: repoint default_env to SUPERUSER in runjob

[dannyadair]

runjob is declared auth="none", so _auth_method_none pins request.env and transaction.default_env to a uid=None env. env = http.request.env( user=SUPERUSER_ID) only creates a local superuser env, leaving the default_env as uid=None. Any flush that goes through Transaction.flush() -> default_env.flush_all() then recomputes stored fields as uid=None and fails on anything dereferencing self.env.user.

http.request.update_env(user=SUPERUSER_ID) additionally sets transaction.default_env to the superuser env.

Closes #922

[OCA-git-bot]

Hi @guewen, @sbidoul,
some modules you are maintaining are being modified, check this out!

[dannyadair]

Rebased after #924 was merged.
That PR removed the db/session.db handling but not the uid=None default_env issue this fixes, so the change is unchanged.

[amh-mw]

Seems reasonable after reading the source here and https://github.com/odoo/odoo/blob/19.0/odoo/http.py#L1856-L1867:

    def update_env(self, user=None, context=None, su=None):
        """ Update the environment of the current request.

        :param user: optional user/user id to change the current user
        :type user: int or :class:`res.users record<~odoo.addons.base.models.res_users.ResUsers>`
        :param dict context: optional context dictionary to change the current context
        :param bool su: optional boolean to change the superuser mode
        """
        cr = None  # None is a sentinel, it keeps the same cursor
        self.env = self.env(cr, user, context, su)
        self.env.transaction.default_env = self.env
        threading.current_thread().uid = self.env.uid

That said, why make the change? What problem does this avoid? ☕ Unit test that problem?

[dannyadair]

The problem is described in #922 and solved by this PR.

[amh-mw]

The problem is described in #922 and solved by this PR.

Yep, sorry! Struck through much of my comment already! Still desire a unit test.