Skip to content

fix(tests): stabilize Windows support expiry waits - #400

Merged
veryCrunchy merged 3 commits into
mainfrom
fix/windows-support-expiry-stability
Aug 16, 2026
Merged

fix(tests): stabilize Windows support expiry waits#400
veryCrunchy merged 3 commits into
mainfrom
fix/windows-support-expiry-stability

Conversation

@veryCrunchy

@veryCrunchy veryCrunchy commented Aug 16, 2026

Copy link
Copy Markdown
Member

Summary

  • give the completed-receipt expiry test enough retention time for slower Windows runners
  • give cancellation tests enough time to observe upload, reconciliation, and authoritative tombstone requests
  • keep production support-intake behavior unchanged

Context

Follow-up to #351.

These support-intake tests failed in otherwise unrelated Windows checks for #399 and #403. They used two-second wall-clock boundaries around asynchronous HTTP handling; the Windows runner could legitimately cross those boundaries before the assertion observed the response.

Validation

On the dedicated build host:

  • bash tools/check-repository.sh
  • bash tools/test-prerelease-update-contract.sh
  • focused reruns of JvmSupportIntakeTest.expiresCompletedReceiptWhileTheProcessRemainsOpen, JvmSupportIntakeTest.cancellationAfterUploadResponseCompletesSendsAuthoritativeTombstone, and JvmSupportIntakeTest.cancellationDuringReceiptReconciliationSendsAuthoritativeTombstone
  • full :ui:desktopTest

The original two-test change was fully green, including hosted Windows. The added reconciliation test is being revalidated at ba8ca0fc1404a44d4d7c330f5258e35f471eb529.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #400 / NC Native August 16, 2026 17:08 Destroyed
@obiente-cloud

obiente-cloud Bot commented Aug 16, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · ba8ca0fc1404 · Ready

Open preview

View in Obiente

Obiente updates this comment as the preview changes.

@veryCrunchy veryCrunchy added priority:P1 Required for the pre-release product experience area:platform Android, desktop, iOS, Windows, macOS, and Linux platform work type:reliability Correctness, crash prevention, recovery, and data safety platform:desktop Desktop-specific implementation or validation labels Aug 16, 2026
@veryCrunchy veryCrunchy added this to the 0.6 Platform polish milestone Aug 16, 2026
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #400 / NC Native August 16, 2026 17:09 Destroyed
@veryCrunchy veryCrunchy moved this to In Progress in Nextcloud Native Roadmap Aug 16, 2026
@veryCrunchy
veryCrunchy merged commit 0d69da8 into main Aug 16, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Nextcloud Native Roadmap Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:platform Android, desktop, iOS, Windows, macOS, and Linux platform work platform:desktop Desktop-specific implementation or validation priority:P1 Required for the pre-release product experience type:reliability Correctness, crash prevention, recovery, and data safety

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant