fix(intake): tombstone cancelled submissions - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /api/v1/receiptsoperation that terminally cancels a submission by its hashed idempotency key410 Goneto late or reconciled cancelled submissions, and document the API contractRoot cause and impact
The existing API could delete only after the client had received the server-generated capability. If an upload result was ambiguous and no receipt existed yet, the client had no authoritative way to cancel a request still buffered in transport. A local timeout could therefore either trap the user in recovery or discard the only deletion capability before a delayed private report was committed.
This tombstone is the server-side terminal result consumed by Obiente/nc-native#386. It stores only the one-way idempotency hash and prevents private report creation after cancellation wins the race.
Advances #1.
Validation
gofmt -l internal cmdreturned no filesgo test ./...go vet ./...Validated with Go 1.24 on the dedicated build host.