fix(audit): resolve 4 critical bugs + remove hardcoded credentials - #35
Merged
Conversation
C1: Initialize Limiter + SocketIO in app.py. C2: Implement get_db() + teardown. C3: Fix install.sh password generation syntax. C4: Fix ffmpeg/processor.py global shadowing. Removed default admin/admin from init-db.sql and config.py. Added .dockerignore, j1.yaml, CODEOWNERS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔴 Critical Bugs Fixed
app.py— Limiter + SocketIO never initializedLimiter(app),SocketIO(app),JWTManager(app)app.py—get_db()function missing (NameError on routes)RealDictCursor+ teardowninstall.sh— password generation wrote literal***$()syntax — generates actual random valuesffmpeg/processor.py— global variable shadowing (memory leak)global eventskeyword🔒 Security Fixes
admin/adminfrom seed databaseSECRET_KEY/JWT_SECRET_KEYdefault toos.urandom()📋 Standard Files Added
.dockerignore,j1.yaml,CHANGELOG.md,.github/CODEOWNERS📊 Score
45 → 68/100 (+23 points — biggest improvement in portfolio)