[RichaSapre]

Task

Description

Fixes #48

The public job application form was displaying inactive, retired, internal, and test-related forms or questions to applicants. This caused unrelated or meaningless questions to appear and made it difficult for applicants to identify the correct application form.

This PR updates the frontend filtering logic so that applicants only see active and valid application forms and positions.

Related PRs

None. This is a frontend-only change.

Main changes explained

1. Filter inactive application forms from the applicant-facing form list.
2. Hide retired forms from the applicant-facing form list.
3. Hide internal “APPLIED THROUGH SITE” forms from the applicant-facing form list.
4. Remove inactive, retired, and internal positions from the applicant-facing position dropdown.
5. Use SEEKING SOFTWARE POSITION as the preferred software application form.
6. Add automated tests for applicant-facing form and position filtering.
7. Add comments explaining the new filtering logic.

How to test

1. Start the backend.
2. Start the frontend.
3. Open /job-application.
4. Open the position dropdown.
5. Select SEEKING SOFTWARE POSITION.
6. Verify that the application form loads correctly.
7. Confirm that junk questions such as nnn, pandy, what's this, 666, and Shreyas do not appear.
8. Turn on dark mode.
9. Verify that the questions, inputs, dropdown, and buttons remain readable.
10. Confirm that the form still works in normal mode.

Tests performed

• Focused Vitest tests passed: 11 tests.
• ESLint completed with no errors.
• Git diff check passed.
• Manual testing completed in normal mode and dark mode.

Screenshots

The screenshots below show the cleaned application form and its appearance in dark mode.

Normal mode

Dark mode

[netlify]

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	1342e4f
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6acee908334fda75302abf17
😎 Deploy Preview	https://deploy-preview-5653--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[AlekyaJogini]

Reviewed by Alekya.

How I tested
Checked out the PR branch (commit 1342e4f) on Node 20.19.4 with the backend on development. Confirmed the diff is 3 files (JobApplicationForm.jsx, jobApplicationPublicApi.js and a new test file). Ran npx vitest run jobApplicationPublicApi. Opened /job-application logged out in an Incognito window, and logged in as my Admin test account in dark mode. I did not submit the form.

Verified working

• 1 test file, 11 tests pass.
• Logged out the position dropdown shows only real positions from top to bottom. I did not see inactive, test or "APPLIED THROUGH SITE" entries.

• SEEKING SOFTWARE POSITION loads 12 real questions. None of the junk questions (nnn, pandy, what's this, 666, Shreyas) appear.

• Questions, inputs and placeholders are readable in dark mode.

Issues found
None.

Not tested

• Other positions' question lists
• Submitting an application
• Narrow screen widths

[rahulrubugunday]

Tested locally on pr-5653 at 1342e4f as Admin on /job-application, in light and dark mode. I did not submit an application.

Works

The position dropdown lists only real positions, with no “[RETIRED]”, “APPLIED THROUGH SITE” or test entries. The three retired forms in the dev data (“[RETIRED] APPLIED THROUGH SITE - SEEKING SOFTWARE POSITION”, “[RETIRED] T.A.S.T”, “[RETIRED] Test Create Form”) are not offered.
SEEKING SOFTWARE POSITION loads its 11 real questions (Phone/WhatsApp through “anything else we should know”). None of the junk questions (nnn, pandy, what’s this, 666, Shreyas) appear.
Questions, inputs and the dropdown are readable in both light and dark mode.

Needs changes

Merge conflict with development in JobApplicationForm.jsx. Please merge development into the branch and resolve it so this can be merged.

[snehitakandula]

Reviewed on this PR's branch (pr-5653) at commit 1342e4f, frontend only, with backend on development. Tested /job-application as Admin. I didn't submit the form.

Verified:

1. Tests: npx vitest run jobApplicationPublicApi passes (11 tests).
2. Position dropdown: shows only real positions (e.g. PHOTOSHOP/GRAPHIC DESIGNER, SEEKING ADMINISTRATIVE ASSISTANT, STRAW BALE CLASSROOM STRUCTURAL), with no test, inactive, or "APPLIED THROUGH SITE" entries.
3. Other positions' questions: I checked two positions besides SEEKING SOFTWARE POSITION (which @AlekyaJogini covered). Both load only real questions (e.g. "Is there anything else we should know or that you'd like to share?", "What is your city and timezone?", and the interview-time question), with none of the junk entries.
4. Narrow width: long position names wrap inside the dropdown and stay within the form.

Requesting changes: merge conflict
GitHub now reports a conflict in src/components/Collaboration/JobApplicationForm/JobApplicationForm.jsx, likely from another recent change to the same form (such as #5651, which adds the terms checkbox). Please update the branch from the latest development. The fix itself works as described.

Screenshots:

Position dropdown (real positions only):

Questions for another position (no junk):

Merge conflict reported by GitHub:

Requesting changes.

[AaditTrivedi]

Reviewed by Aadit Trivedi.

The branch has a merge conflict with development in src/components/Collaboration/JobApplicationForm/JobApplicationForm.jsx (checked with git merge-tree). That file was recently changed on development, including the email validation work from #5649.

Required action
Please update the branch with development and resolve the conflict, keeping the new email validation behavior. I'll review the changes once it's updated.

[iAbhi001]

Tested locally on branch pr-5653 at the latest commit (frontend only, backend) on /job-application across both light and dark mode. All 11 unit tests pass, the position dropdown cleanly excludes test, retired, and internal entries, and selecting positions loads only legitimate questions without junk fields. Visual styling and input readability remain solid in both themes. However, requesting changes due to the active merge conflict with development in the job application form component (stemming from recent changes like email validation and terms updates); please rebase on latest development and resolve the conflict so this can be merged.

[AnshShah-18]

I've tested PR #5653 locally and everything looks good. The applicant-facing position dropdown no longer shows retired or internal entries, SEEKING SOFTWARE POSITION loads the correct application form, and the junk/test questions are no longer present. I also verified the form remains readable and functional in both dark and light mode. Everything I tested worked as expected.

Approved—nice work!