Repository navigation
Aditya Dhayapulay - Fix Add Task resources clearing during delayed loading - #5685
Open
adit24dhaya wants to merge 4 commits into
Open
adit24dhaya wants to merge 4 commits into
adit24dhaya wants to merge 4 commits into
Conversation
Preserve task drafts and Resource search state when background task and member responses arrive. Keep failed saves open so users can retry without re-entering their selections. Add regression coverage for delayed refreshes, resets, failed requests, retries, and notification failures after task creation.
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reuse the clock fixture already present on development so dated sample events remain available to the sorting test. Restore real timers after each case; do not change production behavior. Unblock the unrelated date-sensitive CI failure on PR #5685.
Contributor
Author
|
Pushed a test-only fix for the CI failure: the Activity List test now uses a fixed clock so its sample events do not expire as the date changes. This is the same fixture fix already on development; the resource-selection code is unchanged. All 47 focused WBS/detail and Activity List tests passed after the commit, along with lint. New GitHub checks are pending. |
Preserve the original Google Doc request so reviewers can compare the implementation with the assigned requirements.
Restore the previous file tree at the author's request; retain the images locally for manual attachment.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Original task request
Original task in Google Docs
Complete task captured directly from the original document; the requested wording is unchanged.
Fix Jae's high-priority Phase 1 issue: task adding delay for the Resource field that refreshes it.
When task data arrived after the Add Task form opened, it could erase the selected Resources and other draft fields. A change in the member count could also reset Resource search text and focus. The form now keeps those values while background loading finishes.
Failed saves keep the form open with the draft intact for retry. Successful saves close the form, and opening another task starts a fresh draft.
Related PRs
None; frontend only.
Main changes explained
How to test
npm start.Validation: 150 Projects/reducer tests passed, including 20 new regression tests; 120 browser assertions passed across four viewport/theme cases. Production build and changed-file ESLint passed. The commit hook also passed lint checks.
Requests were mocked; browser fixtures used the real form and Resource picker with stubbed rich-text editors. No shared-development data was written. A real-action test confirms a notification failure after task creation still completes the save.
Screenshots or videos of changes
Eight UI screenshots, a code-diff screenshot and a short captioned walkthrough are prepared locally for the weekly submission; media attachments have not yet been uploaded to this PR.
Note
This change targets the Add Task form. Existing dark-dropdown contrast is outside its scope. Testing does not claim a full authenticated end-to-end run or server-side idempotency for a response lost after task creation.