Repository navigation
Aditya Dhayapulay - Add smart search to on-site member table - #5718
Open
adit24dhaya wants to merge 3 commits into
Open
adit24dhaya wants to merge 3 commits into
adit24dhaya wants to merge 3 commits into
Conversation
Add column suggestions, literal match highlighting, combined 350ms-debounced filters and immediate reset. Preserve keyboard focus and readable dark-mode styles while avoiding table-body updates during typing. Implements the medium-priority Jae/Divanshu on-site member search task. Use the existing Project Details table as confirmed; no routing or worker-data API changes.
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Replace generic status/group containers with output and a fieldset with legend, preserving the responsive grid and accessible filter name. Add regression coverage for their native semantics. Resolve both SonarCloud javascript:S6819 findings on PR #5718.
Include the complete Google Doc request so reviewers can compare the implementation with all five requested enhancements. PR #5718
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Original task request
Original task in Google Docs
Complete task captured directly from the original document; the requested wording is unchanged.
Implement the medium-priority Jae/Divanshu: Enhanced Smart Search + UX Improvements for the Members Working on Site Today table task.
Add unique suggestions for First Name, Last Name, Role and Team, literal matching-text highlights, a Clear All Filters button, 350ms debounced filtering, and scoped light/dark styles.
Related PRS (if any)
Frontend only; no paired backend PR or API changes.
Main changes explained
How to test
feat/site-members-smart-searchand use Node20 with the repository's existing dependencies.npx vitest run src/components/BMDashboard/Projects/ProjectDetails/__tests__(24 tests including the existing ProjectDetails test)./bmdashboard/projects/<projectId>).Validation already performed
Screenshots or videos of changes
Nine code/UI screenshots and a short compressed walkthrough are staged in the developer's Week5 media folder. They are not attached to this PR yet.
Note
The task listed
/bmdashboard/tools/day, but that URL resolves to the tool-detail route in current development. Aditya confirmed using the existing Project Details member table instead; this PR does not change routing.The existing table currently displays sample rows. Those are preserved; the new optional
membersprop supports supplied records, but this PR does not introduce live on-site worker-data integration or claim authenticated end-to-end API testing. No task/issue number was supplied, so no unrelated GitHub issue is auto-closed.