Skip to content

chore(phase): overhaul required player amount message loop#136

Draft
theEvilReaper wants to merge 4 commits into
mainfrom
rework/notEnoughPlayers
Draft

chore(phase): overhaul required player amount message loop#136
theEvilReaper wants to merge 4 commits into
mainfrom
rework/notEnoughPlayers

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

When the game is in the LobbyPhase and the phase is paused, an action bar should display how many additional players are required to start the countdown. Unfortunately, the current implementation does not handle this reliably. This pull request overhauls the underlying logic to resolve these issues and make the behavior more robust.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 13, 2026
@theEvilReaper theEvilReaper added the area: game Everything related to the the game module label Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results

114 files  114 suites   50s ⏱️
116 tests 111 ✅  5 💤 0 ❌
351 runs  336 ✅ 15 💤 0 ❌

Results for commit 9450832.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant