Skip to content

refactor: internal id handling#139

Merged
theEvilReaper merged 5 commits into
mainfrom
feature/idHandling
Jul 19, 2026
Merged

refactor: internal id handling#139
theEvilReaper merged 5 commits into
mainfrom
feature/idHandling

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

Currently, the game uses ID values to represent teams, states, and other entities. These IDs are globally scoped, which makes it difficult to understand what each ID represents and where it is used. The goal of this pull request is to isolate IDs and limit them to their respective contexts. This makes it clearer what each ID is intended for.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 19, 2026
@theEvilReaper theEvilReaper added area: api Everything related to the the api module area: game Everything related to the the game module labels Jul 19, 2026
@theEvilReaper
theEvilReaper marked this pull request as ready for review July 19, 2026 14:58
@github-actions

Copy link
Copy Markdown
Contributor

Test results

108 files  108 suites   53s ⏱️
114 tests 109 ✅  5 💤 0 ❌
345 runs  330 ✅ 15 💤 0 ❌

Results for commit 2cbacc5.

@theEvilReaper
theEvilReaper merged commit b0dcd0d into main Jul 19, 2026
8 checks passed
@theEvilReaper
theEvilReaper deleted the feature/idHandling branch July 19, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: api Everything related to the the api module area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant