Repository navigation
fix: [SDK-5574] link the dashboard pages the skills send the user to - #77
Merged
Merged
Conversation
This was referenced Oct 19, 2026
sherwinski
force-pushed
the
sherwin/sdk-5574
branch
from
October 19, 2026 20:40
3c53c0a to
29d2b44
Compare
sherwinski
added this pull request to stack #67
October 19, 2026 23:49
sherwinski
requested review from
abdulraqeeb33 and
kalley
and removed request for
abdulraqeeb33
October 20, 2026 20:28
abdulraqeeb33
approved these changes
Oct 22, 2026
abdulraqeeb33
left a comment
abdulraqeeb33
left a comment
Contributor
There was a problem hiding this comment.
Checked the new URLs against the dashboard's route table: /apps, /apps/new, and /apps/:appId/settings/push/:tab all exist, and the dashboard itself builds push/platforms. Approving.
One non-blocking gap. The credentials skill still sends the user to the same page without the link in four places:
skills/credentials/SKILL.md:165: the 404 fallback to the dashboard upload.skills/credentials/SKILL.md:211: the wrong-but-valid FCM file caveat.skills/credentials/SKILL.md:213: the 404 bullet in the validation loop.skills/credentials/api-uploaded-credentials.md:105: the 404 row.
The description says each dashboard step now gets a link, so these could reuse the URL from fallback 3.
Collaborator
Author
|
Added the URL at the 4 places you listed, plus the |
Dogfooding testers were told to create the app "in the OneSignal dashboard" with no link. The setup skill now sends the app list, the Keys & IDs page, and the new-app page as URLs in Step 2, and the Push Platforms page in the Step 3 fallback. The credentials skill sends the same Push Platforms page on the manual-upload fallback. The routes come from the dashboard router (`/apps/new`, `/apps/:appId/settings/keys_and_ids`, `/apps/:appId/settings/push/platforms`).
Step 2 asked for the App ID and, in the same ask, gave a Keys & IDs URL that needs that App ID. The ask now sends the app list URL and names the page path in words. The sign-in note moves above the list, so it comes with the first link, not the last.
Each place that routes the user to the dashboard upload now sends the same URL as the no-key fallback: the 404 cases, the wrong-but-valid FCM file, and the .p12 case.
sherwinski
force-pushed
the
sherwin/sdk-5574
branch
from
October 22, 2026 20:51
87647f0 to
4b66925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Line Summary
The
setupandcredentialsskills now send a clickable dashboard URL at each step that tells the user to go to the OneSignal dashboard.Motivation
Users will reach the "Create the app in the OneSignal dashboard" but are instructed to go find the correct location in OneSignal themselves. The
verifyskill already sends the Keys & IDs page as a URL; this PR gives the other 2 skills the same behavior.Affected code
skills/setup/SKILL.mdskills/credentials/SKILL.mdskills/verify/SKILL.mdscripts/references/