Repository navigation
feat: [SDK-5562] check the stored APNs Bundle ID and guide the no-key case - #82
Open
sherwinski wants to merge 1 commit into
Open
sherwinski wants to merge 1 commit into
sherwinski wants to merge 1 commit into
Conversation
The view-app read already returns apns_bundle_id, the Bundle ID that OneSignal sends to APNs as the topic. The script now prints it under platforms.apns.bundle_id, and the credentials and setup skills compare it with the project's Bundle ID when APNs is configured. A mismatch is the one stored-credential fault visible before a test send. When the presence check cannot run, the credentials skill now sends the Push Platforms URL and asks the user what the dashboard shows, instead of a portal walkthrough that may create a key the team already has. The .p8 flow says that a key is team-level, that Apple allows 2 per team, and which key scopes do not cover this app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-Line Summary
The credentials check now compares the stored APNs Bundle ID with the project's Bundle ID, and the no-key case asks the user what the dashboard shows instead of a portal walkthrough.
Ticket: SDK-5562
Details
The view-app read already returns
apns_bundle_id, the topic OneSignal sends to APNs with every push;onesignal_api.py appnow prints it asplatforms.apns.bundle_id, and the credentials skill (Step 1, item 4) and the setup skill (Step 3) compare it with the project's Bundle ID when APNs is configured. When the presence check cannot run (an MCP-only session has no view-app read), the credentials skill sends the Push Platforms URL and asks one structured question about what the page shows. The.p8flow now says that a key is team-level, that Apple allows 2 APNs keys per team, and which key scopes do not cover this app.Notes
.p8-first, and.p12is dashboard-only by design. The tester's 2 problems were the missing view-app read in the hosted MCP (list_appsreturns app-table fields only; fixed server-side or not at all) and a Bundle ID that did not match the stored credential, which the presence check did not compare.view_apptool inmcp-httpwould make Step 1 work without a REST key.evals/onesignal-api-test.py) goes to the evals repository in its own PR.Testing
onesignal-api-test.py(local, 52 passed, 2 newbundle_idasserts)credentials_p12Affected areas
skills/setup/SKILL.mdskills/setup/assets/skills/credentials/SKILL.mdskills/verify/SKILL.mdscripts/references/