Repository navigation
feat: [SDK-5566] install the iOS SDK from OneSignal-XCFramework with the NSE and App Group - #83
Open
sherwinski wants to merge 2 commits into
Open
sherwinski wants to merge 2 commits into
sherwinski wants to merge 2 commits into
Conversation
A pbxproj snippet in a skill carries an rpath with ../../ in it. That text goes into the user's project and is not a link the plugin resolves, so the gate now skips fenced code blocks for the parent-segment check only. A new self-test case keeps a ../ in prose rejected.
… App Group The resolver's SPM line now names the OneSignal-XCFramework package and the product-to-target map; the Podfile output gains the in-app messages subspec and a line for the extension target. The default product set is OneSignalFramework and OneSignalInAppMessages on the app target and OneSignalExtension on the extension; OneSignalLocation is added only on request. The Notification Service Extension and the App Group are now part of the default native iOS install. ios-nse.md holds the recipe, 3 new templates hold the extension files, compile_check_ios.sh compiles the Swift one against a stub of OneSignalExtension.h, and verify_integration.py checks the target, the link, and the shared App Group. The safety and telemetry contracts, the platform matrix, and the prior-install detection follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-Line Summary
Native iOS setup installs the SDK from
OneSignal-XCFrameworkwith the documented product-to-target map, and creates the Notification Service Extension and App Group by default.Ticket: SDK-5566
Details
The resolver's SPM line now names
OneSignal-XCFramework(the bug-bash run pinnedOneSignal-iOS-SDK, the source repository) withOneSignalFramework+OneSignalInAppMessageson the app target andOneSignalExtensionon the extension; the Podfile output matches the documentation's 2 target blocks.ios.mdmakes the NSE and App Group part of the default install, with the recipe in the newios-nse.mdand 3 new templates;verify_integration.pychecks the target, the link, and the shared App Group. The safety contract §8, the telemetry contract, and the platform matrix say the same.Notes
OneSignalInAppMessagesis in by default (the documentation marks it Recommended, and it needs no code).OneSignalLocationis out unless the user's request names location; the summary mentions it in one sentence. No new question.OneSignal-iOS-SDK;OneSignal-XCFrameworkpublishes the same tags, so the pin applies to both (checked: tags 5.5.1 to 5.8.0 exist in both). The "Add XCFramework channels to sdk-releases" item from the ticket is a change in the sdk-releases repository and is not in this PR.capability_manualclass.../check, because the rpath in the pbxproj snippet needs../../. A self-test case keeps a../in prose rejected.cross-platform.md) keep the NSE optional; this PR covers native iOS only.Testing
compile_check_ios.sh(3 templates compile or lint; 3 negative controls rejected)verify_integration.py --platform ioson a scratch fixture: good tree passes; missingNotificationService.swift→ warn; App Group mismatch → errorresolve_sdk_version.py ios(json, podfile, podfile-nse)package_directory_bundle.py --checkand--self-testAffected areas
skills/setup/SKILL.mdskills/setup/assets/skills/credentials/SKILL.mdskills/verify/SKILL.mdscripts/references/