Skip to content

fix: stabilize observer lifecycle and asynchronous state snapshots - #1974

Open
OskarEichler wants to merge 1 commit into
OneSignal:mainfrom
OskarEichler:codex/onesignal-observer-lifecycle
Open

fix: stabilize observer lifecycle and asynchronous state snapshots#1974
OskarEichler wants to merge 1 commit into
OneSignal:mainfrom
OskarEichler:codex/onesignal-observer-lifecycle

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Clean up listeners across module reloads, make native subscriptions and internal observers idempotent, dispatch a stable listener snapshot, and keep newer permission/subscription events from being overwritten by startup reads. Handle rejected startup reads without unhandled promise rejections. Restore default foreground display when the final JS foreground listener has been removed.

Compatibility and observable changes

No public signature or native SDK version changes. Listener mutations apply to the next event dispatch; a self-removing handler no longer skips the following handler. Notifications without a remaining foreground listener display normally. Active handlers retain suppression and deferred-display control. Startup getter failures now produce one warning instead of an unhandled rejection.

Details

Motivation

The source audit reproduced the failure paths described below. This PR contains only the associated fix; unrelated audit changes are in separate PRs.

Scope

  • src/index.ts
  • src/events/EventManager.ts

Testing

10 independently applied external JS diagnostics, including eight reproduced baseline failures and active-suppression controls. Existing 262 tests and unchanged coverage thresholds pass. This does not implement the native waiting/timeout API proposed in #1859.

Each code/tooling fix was also applied independently to upstream commit a70312207cf094ac361eaa9196c317acb175c2cd and passed its targeted external actual-source diagnostics. Documentation snippets were checked separately. Native diagnostic harnesses use bridge/SDK doubles and are not an end-to-end push test.

On the combined audit branch:

  • Existing SDK suite: 5 files, 262 tests pass; unchanged 95% coverage thresholds pass.
  • vp check: formatting, lint and type checks pass; native Spotless check passes.
  • Both example apps: Android Debug and unsigned iOS Simulator builds pass.
  • Both example apps: iOS and Android production Metro bundles pass.

No checked-in test files were added or modified; regression evidence comes from external diagnostic harnesses and the existing suite. No physical-device, live notification delivery, Appium/BrowserStack, or release-workflow execution is claimed. The no-location example's stale native lock was updated locally to resolve the current SDK for verification; generated locks are not part of this PR.

Checklist

  • Required description sections completed.
  • Scope and observable/API behavior explained.
  • Diff reviewed and targeted regression checks run.
  • Automated checks and device-testing limitations documented.

@OskarEichler
OskarEichler requested a review from a team as a code owner August 27, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant