fix: stabilize observer lifecycle and asynchronous state snapshots - #1974
Open
OskarEichler wants to merge 1 commit into
Open
fix: stabilize observer lifecycle and asynchronous state snapshots#1974OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Clean up listeners across module reloads, make native subscriptions and internal observers idempotent, dispatch a stable listener snapshot, and keep newer permission/subscription events from being overwritten by startup reads. Handle rejected startup reads without unhandled promise rejections. Restore default foreground display when the final JS foreground listener has been removed.
Compatibility and observable changes
No public signature or native SDK version changes. Listener mutations apply to the next event dispatch; a self-removing handler no longer skips the following handler. Notifications without a remaining foreground listener display normally. Active handlers retain suppression and deferred-display control. Startup getter failures now produce one warning instead of an unhandled rejection.
Details
Motivation
The source audit reproduced the failure paths described below. This PR contains only the associated fix; unrelated audit changes are in separate PRs.
Scope
src/index.tssrc/events/EventManager.tsTesting
10 independently applied external JS diagnostics, including eight reproduced baseline failures and active-suppression controls. Existing 262 tests and unchanged coverage thresholds pass. This does not implement the native waiting/timeout API proposed in #1859.
Each code/tooling fix was also applied independently to upstream commit
a70312207cf094ac361eaa9196c317acb175c2cdand passed its targeted external actual-source diagnostics. Documentation snippets were checked separately. Native diagnostic harnesses use bridge/SDK doubles and are not an end-to-end push test.On the combined audit branch:
vp check: formatting, lint and type checks pass; native Spotless check passes.No checked-in test files were added or modified; regression evidence comes from external diagnostic harnesses and the existing suite. No physical-device, live notification delivery, Appium/BrowserStack, or release-workflow execution is claimed. The no-location example's stale native lock was updated locally to resolve the current SDK for verification; generated locks are not part of this PR.
Checklist