Skip to content

fix(ios): forward every application delegate assignment - #1979

Open
OskarEichler wants to merge 1 commit into
OneSignal:mainfrom
OskarEichler:codex/onesignal-ios-delegate-assignment
Open

fix(ios): forward every application delegate assignment#1979
OskarEichler wants to merge 1 commit into
OneSignal:mainfrom
OskarEichler:codex/onesignal-ios-delegate-assignment

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Limit one-time swizzle installation to dispatch_once, while forwarding every delegate assignment. An initial nil delegate no longer consumes the installation token.

Compatibility and observable changes

Setting a replacement delegate or clearing it with nil now reaches UIApplication as expected. The first non-null delegate class is still swizzled once; no broader reswizzling behavior is introduced.

Details

Motivation

The source audit reproduced the failure paths described below. This PR contains only the associated fix; unrelated audit changes are in separate PRs.

Scope

  • ios/RCTOneSignal/UIApplication+RCTOnesignal.m

Testing

Compiled real category code with Foundation/Objective-C runtime and UIApplication/delegate doubles; baseline replacement and clearing fail, and all three assignment checks pass fixed.

Each code/tooling fix was also applied independently to upstream commit a70312207cf094ac361eaa9196c317acb175c2cd and passed its targeted external actual-source diagnostics. Documentation snippets were checked separately. Native diagnostic harnesses use bridge/SDK doubles and are not an end-to-end push test.

On the combined audit branch:

  • Existing SDK suite: 5 files, 262 tests pass; unchanged 95% coverage thresholds pass.
  • vp check: formatting, lint and type checks pass; native Spotless check passes.
  • Both example apps: Android Debug and unsigned iOS Simulator builds pass.
  • Both example apps: iOS and Android production Metro bundles pass.

No checked-in test files were added or modified; regression evidence comes from external diagnostic harnesses and the existing suite. No physical-device, live notification delivery, Appium/BrowserStack, or release-workflow execution is claimed. The no-location example's stale native lock was updated locally to resolve the current SDK for verification; generated locks are not part of this PR.

Checklist

  • Required description sections completed.
  • Scope and observable/API behavior explained.
  • Diff reviewed and targeted regression checks run.
  • Automated checks and device-testing limitations documented.

@OskarEichler
OskarEichler requested a review from a team as a code owner August 27, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant