Repository navigation
test: [SDK-5501] add cold-start and background notification tap tests - #57
Merged
Merged
Conversation
fadi-george
force-pushed
the
fadi/sdk-5501
branch
2 times, most recently
from
October 13, 2026 17:54
7ce6555 to
860bdb2
Compare
fadi-george
added this pull request to stack #59
October 13, 2026 17:58
fadi-george
marked this pull request as ready for review
October 13, 2026 17:58
sherwinski
reviewed
Oct 13, 2026
…ap tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The launch URL opening only proves the native SDK handled the tap. Also check the demo's log view for exactly one click entry with the sent notification id, which catches missing or duplicate replays in the wrapper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nch URL Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi/sdk-5501
branch
from
October 13, 2026 20:26
88aa312 to
101c290
Compare
sherwinski
reviewed
Oct 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sherwinski
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
13_notification_clickto cover tapping a push notification after the app is killed (cold start) or backgrounded. This catches wrappers that drop or duplicate the click when it arrives before the JS layer has initialized (e.g. the Capacitor off-main replay bug).Stacked on #56 (uses its log view helpers).
Details
Notification click: <id>for the sent notification. Skipped for demos without a log view.getAppState,terminateApp,backgroundApp,getForegroundAppId,tapNotification(app.ts);isPushSubscriptionReady, andsendPushNotificationwhich returns the notification id (selectors.ts).Draft: not yet verified end to end. Android runs so far failed on environment issues before reaching the new assertion (stale Appium without
ANDROID_HOME, FCM not delivering the first push to a fresh token, WebView context not attaching on reruns). Needs a clean iOS and Android run.🤖 Generated with Claude Code