Add debug-sequences-conf trace-setup in cbuild-run#2521
Conversation
8c3d946 to
66fb9f3
Compare
Test Results 2 files 14 suites 13m 32s ⏱️ Results for commit 66fb9f3. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
=======================================
Coverage 65.35% 65.36%
=======================================
Files 147 147
Lines 26779 26785 +6
Branches 16222 16227 +5
=======================================
+ Hits 17502 17507 +5
Misses 7074 7074
- Partials 2203 2204 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
grasci-arm
left a comment
There was a problem hiding this comment.
One serious issue: the new debug-sequences-conf emission is enabled for any non-legacy traceSetup value, which can silently write unsupported/invalid values into cbuild-run output and schema validation. The added tests also do not cover the fallback/default behavior when traceSetup is absent.
The |
Fixes
debug-sequences-confnode in *.cbuild-run.yml file cmsis-toolbox#650Changes
traceSetupdebug sequence attribute when collecting run/debug settingsdebug-sequences-confsection withtrace-setupnode intocbuild-run.ymldebug-sequences-conf.trace-setupwith supported values (legacy,full)traceSetup="full"and extend unit coverage to verify the generatedcbuild-run.ymlChecklist
Risk / limitations / follow-up
traceSetupvalue is notlegacy, so existing legacy configurations remain unchangedfullcase; other supported values rely on schema validation and the same code path