Skip to content

Add debug-sequences-conf trace-setup in cbuild-run#2521

Merged
brondani merged 1 commit into
mainfrom
projmgr-debug-sequences-conf
Jul 16, 2026
Merged

Add debug-sequences-conf trace-setup in cbuild-run#2521
brondani merged 1 commit into
mainfrom
projmgr-debug-sequences-conf

Conversation

@brondani

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • capture the device traceSetup debug sequence attribute when collecting run/debug settings
  • add a new debug-sequences-conf section with trace-setup node into cbuild-run.yml
  • extend the projmgr run/debug data model, YAML keys, and YAML emission to support the new section
  • update the common schema to validate debug-sequences-conf.trace-setup with supported values (legacy, full)
  • update test DFP pack data to include traceSetup="full" and extend unit coverage to verify the generated cbuild-run.yml

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Risk / limitations / follow-up

  • the new section is only emitted when the effective traceSetup value is not legacy, so existing legacy configurations remain unchanged
  • coverage currently validates the full case; other supported values rely on schema validation and the same code path

@brondani
brondani force-pushed the projmgr-debug-sequences-conf branch from 8c3d946 to 66fb9f3 Compare July 14, 2026 12:51
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Test Results

  2 files   14 suites   13m 32s ⏱️
475 tests 475 ✅ 0 💤 0 ❌
950 runs  950 ✅ 0 💤 0 ❌

Results for commit 66fb9f3.

♻️ This comment has been updated with latest results.

@brondani
brondani requested a review from grasci-arm July 14, 2026 13:08
@brondani
brondani marked this pull request as ready for review July 14, 2026 13:08
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.36%. Comparing base (90796d7) to head (66fb9f3).

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRunDebug.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   65.35%   65.36%           
=======================================
  Files         147      147           
  Lines       26779    26785    +6     
  Branches    16222    16227    +5     
=======================================
+ Hits        17502    17507    +5     
  Misses       7074     7074           
- Partials     2203     2204    +1     
Flag Coverage Δ
projmgr-cov 87.99% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrRunDebug.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgrCbuildRun.cpp 95.76% <100.00%> (+0.04%) ⬆️
tools/projmgr/src/ProjMgrRunDebug.cpp 87.57% <66.66%> (-0.13%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grasci-arm grasci-arm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One serious issue: the new debug-sequences-conf emission is enabled for any non-legacy traceSetup value, which can silently write unsupported/invalid values into cbuild-run output and schema validation. The added tests also do not cover the fallback/default behavior when traceSetup is absent.

@brondani

Copy link
Copy Markdown
Collaborator Author

One serious issue: the new debug-sequences-conf emission is enabled for any non-legacy traceSetup value, which can silently write unsupported/invalid values into cbuild-run output and schema validation. The added tests also do not cover the fallback/default behavior when traceSetup is absent.

The traceSetup in PDSC is guarded by TraceSetupEnum in xml schema, while the trace-setup emission is guarded by yml schema "enum": ["legacy", "full"]. Default behaviour regression will be caught by several other untouched cbuild-run.yml golden references. No further check is needed.

@brondani
brondani requested review from edriouk and soumeh01 July 14, 2026 13:26

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani
brondani merged commit a3a8905 into main Jul 16, 2026
38 checks passed
@brondani
brondani deleted the projmgr-debug-sequences-conf branch July 16, 2026 14:21
@brondani
brondani removed the request for review from soumeh01 July 16, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants