feat(pyoaev): transport source-declared injector_author on registration (#311)#312
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for transporting an optional, source-declared injector_author field when registering an injector, enabling the OpenAEV platform to attribute injector contracts to the specified organization.
Changes:
- Add
injector_authorto the injector registration payload constructed byOpenAEVInjectorHelper. - Add
injector_authorto theInjectorManagercreate attributes definition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyoaev/helpers.py | Includes injector_author in the injector registration payload built by OpenAEVInjectorHelper. |
| pyoaev/apis/injector.py | Documents/permits injector_author as an optional field when creating injectors via the API manager. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Review-and-fix pass complete - no code changes were needed:
Note: I cannot approve this PR since I am its author - it needs an approving review from another maintainer to unblock merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #311
Summary
The platform (OpenAEV-Platform/openaev#6784) attributes every contract of the injector to an organization of this name; when absent it derives the author from the injector name, so this change is fully backward compatible.