Skip to content

feat(pyoaev): transport source-declared injector_author on registration (#311)#312

Merged
SamuelHassine merged 1 commit into
mainfrom
feat/injector-author
Jul 19, 2026
Merged

feat(pyoaev): transport source-declared injector_author on registration (#311)#312
SamuelHassine merged 1 commit into
mainfrom
feat/injector-author

Conversation

@SamuelHassine

Copy link
Copy Markdown
Member

Related issue

Closes #311

Summary

  • Add injector_author to the injector registration payload (InjectorManager attribute allow-list).
  • OpenAEVInjectorHelper reads injector_author from the connector configuration (source-declared, default None) and sends it at registration.

The platform (OpenAEV-Platform/openaev#6784) attributes every contract of the injector to an organization of this name; when absent it derives the author from the injector name, so this change is fully backward compatible.

Copilot AI review requested due to automatic review settings July 19, 2026 16:25
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jul 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for transporting an optional, source-declared injector_author field when registering an injector, enabling the OpenAEV platform to attribute injector contracts to the specified organization.

Changes:

  • Add injector_author to the injector registration payload constructed by OpenAEVInjectorHelper.
  • Add injector_author to the InjectorManager create attributes definition.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyoaev/helpers.py Includes injector_author in the injector registration payload built by OpenAEVInjectorHelper.
pyoaev/apis/injector.py Documents/permits injector_author as an optional field when creating injectors via the API manager.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyoaev/helpers.py
@SamuelHassine

Copy link
Copy Markdown
Member Author

Review-and-fix pass complete - no code changes were needed:

  • Independent review done against the platform consumers: InjectorCreateInput binds injector_author and InjectorService.resolveInjectorAuthor falls back to the injector name when the value is null or blank, so the transport is correct and fully backward compatible. The helper is the single injector registration path in pyoaev, so no other wiring is needed.
  • Addressed the Copilot comment about sending JSON null instead of omitting the key: absent and null are indistinguishable server-side (Jackson binds both to Java null on a String field), the name fallback triggers identically in both cases including on PingAlive re-registrations, and explicit null matches the existing payload pattern for the other unset optional fields. Replied with the justification and resolved the thread.
  • Verified locally on the branch: 164 tests pass, black and isort clean on the touched files. All CI checks are green, the commit is signed, the PR is linked to feat(injector): transport a source-declared injector author on registration #311 and the title matches the repository convention.

Note: I cannot approve this PR since I am its author - it needs an approving review from another maintainer to unblock merge.

@SamuelHassine
SamuelHassine merged commit 6d649c7 into main Jul 19, 2026
16 checks passed
@SamuelHassine
SamuelHassine deleted the feat/injector-author branch July 19, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(injector): transport a source-declared injector author on registration

3 participants