Add RELEASING.md - #202
Add RELEASING.md#202Sekator778 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
I think it looks fine, but check the two comments. At least one of them looks like valid feedback. |
Thorsrud22
left a comment
There was a problem hiding this comment.
Checked this against the workflow, pom.xml, the tags and the #71 convention. Steps 1–4 match how 0.2.12 went (#194 → v0.2.12 → #198 → OpenAPITools/openapi-generator#25096). A few things before it merges:
deployenvironment: both bot comments hold. The repo has adeployenvironment, butmaven_release.ymlnever references it (noenvironment:key), so its protection rules don't apply to the publish job. Either drop "through thedeployenvironment", or addenvironment: deploytopublish-OSSRH, which would also let releases be gated on a required reviewer if that's wanted.- scm tag: the tag value is
jackson-databind-nullable-0.2.N-SNAPSHOT→jackson-databind-nullable-0.2.N, so it's worth spelling out in step 1 (and step 3). - Between steps 1 and 3: the #71 convention lets anyone merge green Dependabot minor/patch bumps, and those are exactly what turned up during 0.2.12 (#195–#197). I'd say explicitly that the freeze includes Dependabot PRs.
- "A failed run publishes nothing": true when the build job fails. With
autoPublishon, though, the publish step uploads and then waits for validation, so if that step fails after the upload (e.g. a timeout), the deployment can still go through. Suggest: "if the publish step itself failed, check Maven Central and the Central Portal before pushing again."
Approving, since these are wording fixes.
Drop the deploy environment (the workflow doesn't use it), spell out the scm tag, say the freeze covers Dependabot, and what to check when the publish step fails.
|
Thanks both, all four are right. Pushed 445ad7e: the |
Writes down how a release is cut here, as I offered in #71. @nrayburn-tech @Thorsrud22 could one of you review? cc @wing328
Summary by cubic
Adds
RELEASING.mdto document how releases are cut for this repository.Written for commit 445ad7e. Summary will update on new commits.