-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat: add optional getters for nullable fields #24039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorgerod
wants to merge
39
commits into
OpenAPITools:master
Choose a base branch
from
InditexTech:feature/GH-24002-optional
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
bde43b4
feat: add optional getters for nullable fields
jorgerod 0cb169d
chore: solved conflicts
jorgerod 16d08a3
fix: update generated annotation version in EnumConverterConfiguration
jorgerod 8a9121b
feat: add optional getters for nullable fields
jorgerod 5e85ed2
style: fix indentation in nullable getters
jorgerod 7a25329
feat: add configuration files for optional getters in Java clients
jorgerod f1c6dde
chore: initialize project structure and add configuration files
jorgerod ecbb9cb
feat: propagate discriminator property to subtype models for optional…
jorgerod e32abbb
feat: update optional getters description for non-required fields
jorgerod eb831e9
Merge branch 'master' into feature/GH-24002-optional
jorgerod 5e30ce3
Merge branch 'master' into feature/GH-24002-optional
jorgerod 37ccc89
feat: update optional getters description for non-required fields
jorgerod ddc8cfe
Merge branch 'master' into feature/GH-24002-optional
jorgerod c524f59
chore: solved conflicts
jorgerod 6d82076
refactor: update descriptions and remove deprecated options in config…
jorgerod e8f55a6
Merge branch 'master' into feature/GH-24002-optional
jorgerod fbd92e3
chore: update version to 7.26.0-SNAPSHOT and bump dependencies
jorgerod bb6082b
docs: add API documentation for FileApi and RequiredAndNullableApi
jorgerod 4e1abb8
docs: add new PHP keywords to documentation
jorgerod 0d2f1de
Merge branch 'master' into feature/GH-24002-optional
jorgerod c1832f7
Merge branch 'master' into feature/GH-24002-optional
jorgerod cc5a645
refactor: remove insecure TLS certificate validation method from ApiC…
jorgerod dcd811b
Merge branch 'master' into feature/GH-24002-optional
jorgerod a2c8be7
Merge branch 'master' into feature/GH-24002-optional
jorgerod bb7840f
Merge branch 'feature/GH-24002-optional' of github.com:InditexTech/fo…
jorgerod 4784547
docs: update elixir documentation for library option
jorgerod 46c57cf
Merge branch 'master' into feature/GH-24002-optional
jorgerod 2f91fcc
refactor: add method to disable X.509 certificate validation in TLS c…
jorgerod d4319f3
refactor: add method to disable X.509 certificate validation in ApiCl…
jorgerod 9926fb9
chore: fix format
jorgerod a16c7fb
Update samples/client/petstore/java/resttemplate-springBoot4-jackson3…
jorgerod 65983d9
fix: address cubic-dev-ai review feedback
jorgerod 61d2810
fix: expose optionalGettersForNullableFieldsOnly only in supporting g…
jorgerod 6e4560f
fix: generate Java 17/21 JDKs in .travis.yml for Spring Boot 4 samples
jorgerod 1717b5c
chore: remove unused test files from repository
jorgerod 9b40745
fix: complete Optional getter support for Jackson 2 and custom mappers
jorgerod b79d526
test: add unit tests for FileApi, FooApi, RequiredAndNullableApi, and…
jorgerod 24c34f1
refactor: restrict optionalGettersForNullableFieldsOnly to jackson 3
jorgerod 04b08b5
fix: require jackson 3 for optional getters for nullable fields
jorgerod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
bin/configs/java-restclient-springBoot4-jackson3-jspecify-optional-getters.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| generatorName: java | ||
| outputDir: samples/client/petstore/java/restclient-springBoot4-jackson3-jspecify-optional-getters | ||
| library: restclient | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/java/jspecify.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/Java | ||
| validateSpec: false | ||
| additionalProperties: | ||
| artifactId: petstore-restclient-optional-getters | ||
| hideGenerationTimestamp: "true" | ||
| containerDefaultToNull: "true" | ||
| useSpringBoot4: true | ||
| useJackson3: true | ||
| openApiNullable: false | ||
| useJspecify: true | ||
| optionalGettersForNullableFieldsOnly: "true" | ||
| typeMappings: | ||
| OffsetDateTime: java.time.Instant | ||
| BigDecimal: java.math.BigDecimal |
19 changes: 19 additions & 0 deletions
19
bin/configs/java-resttemplate-springBoot4-jackson3-jspecify-optional-getters.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| generatorName: java | ||
| outputDir: samples/client/petstore/java/resttemplate-springBoot4-jackson3-jspecify-optional-getters | ||
| library: resttemplate | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/java/jspecify.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/Java | ||
| validateSpec: false | ||
| additionalProperties: | ||
| artifactId: petstore-resttemplate-optional-getters | ||
| hideGenerationTimestamp: "true" | ||
| containerDefaultToNull: "true" | ||
| useJakartaEe: true | ||
| useSpringBoot4: true | ||
| useJackson3: true | ||
| openApiNullable: false | ||
| useJspecify: true | ||
| optionalGettersForNullableFieldsOnly: "true" | ||
| typeMappings: | ||
| OffsetDateTime: java.time.Instant | ||
| BigDecimal: java.math.BigDecimal |
18 changes: 18 additions & 0 deletions
18
bin/configs/java-webclient-springBoot4-jackson3-jspecify-optional-getters.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| generatorName: java | ||
| outputDir: samples/client/petstore/java/webclient-springBoot4-jackson3-jspecify-optional-getters | ||
| library: webclient | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/java/jspecify.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/Java | ||
| validateSpec: false | ||
| additionalProperties: | ||
| artifactId: petstore-webclient-optional-getters | ||
| hideGenerationTimestamp: "true" | ||
| containerDefaultToNull: "true" | ||
| useSpringBoot4: true | ||
| useJackson3: true | ||
| openApiNullable: false | ||
| useJspecify: true | ||
| optionalGettersForNullableFieldsOnly: "true" | ||
| typeMappings: | ||
| OffsetDateTime: java.time.Instant | ||
| BigDecimal: java.math.BigDecimal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| generatorName: spring | ||
| library: spring-boot | ||
| outputDir: samples/openapi3/server/petstore/springboot-4-jspecify-optional-getters | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/java/jspecify.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/JavaSpring | ||
| validateSpec: false | ||
| additionalProperties: | ||
| groupId: org.openapitools.openapi3 | ||
| documentationProvider: springdoc | ||
| interfaceOnly: true | ||
| artifactId: springboot-optional-getters | ||
| snapshotVersion: "true" | ||
| useSpringBoot4: true | ||
| useJackson3: true | ||
| useBeanValidation: true | ||
| withXml: true | ||
| hideGenerationTimestamp: "true" | ||
| generateConstructorWithAllArgs: true | ||
| generateBuilders: true | ||
| openApiNullable: false | ||
| useJspecify: true | ||
| optionalGettersForNullableFieldsOnly: "true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.