fix(typescript): serialize JSON header parameter content - #25088
Open
AndreyVMarkelov wants to merge 1 commit into
Open
AndreyVMarkelov wants to merge 1 commit into
AndreyVMarkelov wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
AndreyVMarkelov
force-pushed
the
fix/typescript-json-header
branch
from
October 1, 2026 21:47
1cc3c26 to
603ce19
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix JSON-content header serialization for generated model parameters in
typescript-fetchandtypescript-node.For
typescript-fetch, JSON-content headers backed by generated model schemas use the model’s existingToJSONconversion beforeJSON.stringify.For
typescript-node, they useObjectSerializer.serializebeforeJSON.stringify.This preserves OpenAPI wire property names such as
file_pathwhen the generated TypeScript property isfilePath.The same handling applies to JSON structured-suffix media types such as
application/vnd.example+json.typescript-axioswas checked with the same reproduction and already produces the expected JSON header, so no change is needed there.Tests
Focused tests cover:
application/vnd.example+jsonParameterswithoutRuntimeChecks=trueGenerated
typescript-fetchclients compile successfully in both normal mode and withwithoutRuntimeChecks=true.Fixes #25086