Conversation
Both patterns hard-code the digit right after "12PSSSS" to [34]. At least two EF-S7-V1.0.30B units produce a live, well-formed serial.cfg/UOID with digit "5" instead. Confirmed on a three-way verified flash dump that widening this to [3-9] lets build-image find the serial.cfg as live-current and the rebuilt image passes cc2camera's own strict validation end to end. See issue #<номер>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "HWCONFIG UOID field does not have the expected 94-byte ASCII
structure" / "Could not recover exactly one unambiguous CRC-valid
serial.cfg payload (found 0)" errors reported in #21
Both SERIAL_PATTERN and UOID_PATTERN hard-code the digit right after
"12PSSSS" to [34]. At least two EF-S7-V1.0.30B units (one dead, one
still working — see issue comments) produce a live, well-formed
serial.cfg and UOID whose digit is "5" instead.
I confirmed on my own three-way-verified flash dump that:
live-current(not afallback/ambiguous match) once the pattern accepts "5",
already matched the reference firmware exactly, before this change,
post-build validation end to end.
This patch widens the allowed digit from [34] to [3-9] rather than
adding "5" specifically, on the assumption this is a hardware/product
revision marker that may take other values on other batches — happy
to narrow it to [345] if maintainers prefer being conservative.
No other code path branches on this digit's value (checked with
grep across image.py), so this is a pure allowlist widening with no
behavioural side effects for units that already validated.