Repository navigation
fix(synkronus-cli): generate architecture-specific Windows resources - #1044
Merged
najuna-brian merged 4 commits intoNov 9, 2026
Merged
najuna-brian merged 4 commits into
najuna-brian merged 4 commits into
Conversation
najuna-brian
requested changes
Nov 8, 2026
najuna-brian
left a comment
Member
There was a problem hiding this comment.
LGTM, correct root-cause fix, and adding Windows to the PR matrix will catch regressions.
may be some Non-blocking:
(1) note the CRLF→LF normalization in the description since it makes the workflow diff look like a full rewrite;
(2) consider passing the release tag into goversioninfo so Windows file properties don’t always say 1.4.0.0;
(3) *.syso could live in synkronus-cli/.gitignore instead of root.
Contributor
Author
|
Hello @najuna-brian i have managed to make the suggested improvements, could you please review when you get a minute. Thank you |
najuna-brian
self-requested a review
November 9, 2026 10:26
najuna-brian
approved these changes
Nov 9, 2026
najuna-brian
left a comment
Member
There was a problem hiding this comment.
Thanks @Grace256c
Nicely done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Fix Windows CLI builds failing on the committed
resource_windows_amd64.syso.The tracked resource file was named for AMD64 but actually contained an i386 COFF object. Renaming the file did not change its internal architecture, which caused the linker error:
unknown relocation type 7This change removes the precompiled architecture-dependent resource and generates the correct Windows resource during CI/release builds using pinned
goversioninfo@v1.5.0.Windows resources are now generated explicitly for:
-64-64 -armThe generated resources use the current
versioninfo.jsonmetadata and preserve the existing Windows icon.The failure was also reproduced with Go 1.26.8, so the underlying issue is the architecture mismatch rather than a Go 1.27-only regression.
Documentation was updated to describe the architecture-specific generation process and remove stale server resource instructions.
Closes #1025.
Type of Change
Component(s) Changed
Testing
Verification included:
go mod verifygo vet -mod=readonly ./...go test -mod=readonly -race ./...0x86640xaa64OpenDataEnsemblemetadata and version1.4.0.0actionlintgit diff --checkNative Windows execution was not performed locally; Windows behavior is covered through cross-build verification and CI workflow changes.
Checklist
Closes #123Review follow-up
The CLI workflow was normalized from CRLF to LF while editing; this normalization has no behavioral effect.
Following review feedback, this PR also:
*.sysofiles tosynkronus-cli/.gitignore;1.4.0-alpha.2while using the valid numeric Windows version1.4.0.0.