Skip to content

ci: run clippy directly #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerrysxie wants to merge 3 commits into from
Closed

ci: run clippy directly #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95fd792
ci: run clippy directly
jerrysxie Aug 20, 2026
24fd150
ci: track lockfiles for reproducible builds
jerrysxie Aug 20, 2026
8c1a12a
Merge branch 'main' into fixing-workflow
jerrysxie Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 13 additions & 26 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ jobs:
clippy:
runs-on: ubuntu-latest
name: ${{ matrix.toolchain }} / clippy
permissions:
contents: read
checks: write
strategy:
fail-fast: false
matrix:
Expand All @@ -72,26 +69,14 @@ jobs:
- name: rustup target add ${{ matrix.target }}
run: rustup target add ${{ matrix.target }}
- name: cargo clippy (libs)
uses: giraffate/clippy-action@v1
with:
reporter: "github-pr-check"
clippy_flags: -- -F clippy::suspicious -D clippy::correctness -F clippy::perf -F clippy::style
github_token: ${{ secrets.GITHUB_TOKEN }}
workdir: "./libs"
run: cargo clippy --locked --features mimxrt685s -- -F clippy::suspicious -D clippy::correctness -F clippy::perf -F clippy::style
working-directory: "./libs"
- name: cargo clippy (examples)
uses: giraffate/clippy-action@v1
with:
reporter: "github-pr-check"
clippy_flags: -- -F clippy::suspicious -D clippy::correctness -F clippy::perf -F clippy::style
github_token: ${{ secrets.GITHUB_TOKEN }}
workdir: "./examples/rt685s"
run: cargo clippy --locked -- -F clippy::suspicious -D clippy::correctness -F clippy::perf -F clippy::style
working-directory: "./examples/rt685s"
- name: cargo clippy (bootloader-tool)
uses: giraffate/clippy-action@v1
with:
reporter: "github-pr-check"
clippy_flags: -- -D clippy::suspicious -D clippy::correctness -D clippy::perf -D clippy::style
github_token: ${{ secrets.GITHUB_TOKEN }}
workdir: "./bootloader-tool"
run: cargo clippy --locked -- -D clippy::suspicious -D clippy::correctness -D clippy::perf -D clippy::style
working-directory: "./bootloader-tool"

# Enable once we have a released crate
# semver:
Expand Down Expand Up @@ -131,12 +116,12 @@ jobs:
- name: rustup target add ${{ matrix.target }}
run: rustup target add ${{ matrix.target }}
- name: cargo doc (libs)
run: cargo doc --no-deps --features mimxrt685s
run: cargo doc --locked --no-deps --features mimxrt685s
working-directory: "./libs"
env:
RUSTDOCFLAGS: --cfg docsrs
- name: cargo doc (examples)
run: cargo doc --no-deps
run: cargo doc --locked --no-deps
working-directory: "./examples/rt685s"
env:
RUSTDOCFLAGS: --cfg docsrs
Expand Down Expand Up @@ -197,12 +182,14 @@ jobs:
log-level: warn
manifest-path: ./libs/Cargo.toml
command: check
arguments: --locked
- name: Cargo deny (examples)
uses: EmbarkStudios/cargo-deny-action@v2
with:
log-level: warn
manifest-path: ./examples/rt685s/Cargo.toml
command: check
arguments: --locked

msrv:
# check that we can build using the minimal rust version that is specified by this crate
Expand Down Expand Up @@ -231,13 +218,13 @@ jobs:
- name: rustup target add ${{ matrix.target }}
run: rustup target add ${{ matrix.target }}
- name: cargo +${{ matrix.msrv }} check (libs)
run: cargo check --features mimxrt685s
run: cargo check --locked --features mimxrt685s
working-directory: "./libs"
- name: cargo +${{ matrix.msrv }} check (examples)
run: cargo check
run: cargo check --locked
working-directory: "./examples/rt685s"
- name: cargo +${{ matrix.msrv }} check (bootloader-tool)
run: cargo check
run: cargo check --locked
working-directory: "./bootloader-tool"

fuzz:
Expand Down
1 change: 0 additions & 1 deletion examples/rt685s/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
Cargo.lock
/target
/target_ci
Loading
Loading