chore(ci): let java-parent pin the PomChecker version - #47
Merged
Merged
Conversation
The plugin coordinates in build.yml named 1.14.0 explicitly, which is the version java-parent already pins in its pluginManagement — two places to bump instead of one. Maven resolves the version from there when the goal is invoked without it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the explicit
1.14.0from the plugin coordinates in theCheck POMs against the Maven Central rulesstep:Why
java-parentalready pinspomchecker-maven-pluginin itspluginManagement, at that same version. Naming it in the workflow too made it a second place to bump — and a place that could silently drift from the version the reactor otherwise uses. Maven resolves the version frompluginManagementwhen the goal is invoked without one.Verification
Both runs against the current reactor:
--- pomchecker:1.14.0:check-maven-central (default-cli) @ spring-services ---<url>removed fromspring-services-scim/pom.xmlagain → exit 1, with the same message that broke the 1.4.0 release:MavenCentral check failed: <url> is not defined in POM.Identical behaviour to the pinned form.
🤖 Generated with Claude Code