Skip to content

Get the simulation visualization notebook ready to be used as a how-to guide - #359

Open
hannahbaumann wants to merge 7 commits into
mainfrom
prep-analysis-for-howto
Open

hannahbaumann wants to merge 7 commits into
mainfrom
prep-analysis-for-howto

Conversation

@hannahbaumann

Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Colab 👈 Launch a Colab session on branch prep-analysis-for-howto

@atravitz

atravitz commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

This feels like a lot of auxiliary information for a how-to guide. I think this is good as an incremental improvement, but I'm wondering if we should move some of the explanations to the user guide.

@hannahbaumann

Copy link
Copy Markdown
Contributor Author

@atravitz I moved some of the explanations to the user guide, and also added a link to the openfe-analysis API docs for the details on how the transformations are done!

@atravitz atravitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants