Rebuild OHM customizations as logical commits on top of upstream

[Rub21]

This PR replaces the old patch-accumulated history with 12 logical commits that contain all OHM customizations, rebuilt on top of the latest upstream master openstreetmap-website-5a02636.

This is the approach agreed in the ticket OpenHistoricalMap/issues#735 as a cleaner baseline for future development and upstream merges.

cc. @1ec5

[github-actions]

	1 Warning
⚠️	Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?

Generated by 🚫 Danger

[coveralls]

Coverage Report for CI Build 31808287802

Warning

No base build found for commit 5a02636 on staging-new.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.63%

Details

• Patch coverage: 21 uncovered changes across 3 files (24 of 45 lines covered, 53.33%).

Uncovered Changes

File	Changed	Covered	%
lib/date_range.rb	21	5	23.81%
app/helpers/browse_helper.rb	5	2	40.0%
app/controllers/searches/nominatim_queries_controller.rb	12	10	83.33%
Total (9 files)	45	24	53.33%

Coverage Regressions

Requires a base build to compare against. How to fix this →

---

Coverage Stats

Relevant Lines:	7537
Covered Lines:	7283
Line Coverage:	96.63%
Coverage Strength:	891.98 hits per line

---

💛 - Coveralls

[1ec5]

This is looking pretty good. I only inspected the code but haven’t tried running it. I haven’t gone through our issues to see if any features dropped out. It’ll be easier to detect them in testing anyways.

I included some nitpick comments, in case it’s easy enough to remove those from the diffs.¹ The cleaner the diff, the less likely we are to have merge conflicts in the future. Some of the whitespace changes are probably remnants from code that we added and removed at some point.

Footnotes

1. You can do an interactive rebase to rewrite this history. Change pick to edit, edit the file, then continue the rebase. ↩

[Rub21]

Tests are passing now, the map load timing was breaking some tests, so I bumped Capybara's default_max_wait_time so it waits for the page to finish loading.

[1ec5]

Sounds good, it was failing intermittently on other branches for the same reason.