ci(release): make the Telegram binary notification non-blocking#174
Merged
Conversation
The ipctool-release run on master went red even though every build target compiled and both assets uploaded. The only hard failure was the "Send binary to Telegram" step: its `curl --max-time 15` to api.telegram.org timed out (exit 28), and unlike the surrounding `Build sources` / `Create release` steps it had no `continue-on-error`, so a flaky notification gated the whole release. A notification is advisory; it must not fail a release whose build succeeded and whose assets already uploaded. Add `continue-on-error: true` to that step (matching the existing treatment of the build and create-release steps). Note: the "Create release" step still logs a non-fatal `already_exists / tag_name` annotation because all matrix targets race to create the same `latest` tag; it is already `continue-on-error: true`, so it does not fail the run. Left as-is here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ipctool-releaserun onmaster(commite7a0098, the get_hisi_sdk fix) failed despite every build target compiling and both assets uploading. The only hard failure was the Send binary to Telegram step:Unlike the surrounding
Build sourcesandCreate releasesteps (bothcontinue-on-error: true), that notification step had nocontinue-on-error, so a flaky/slow Telegram endpoint gated the whole release.Fix
Add
continue-on-error: trueto Send binary to Telegram — a notification is advisory and must not fail a release whose build succeeded and whose assets already uploaded.Not changed
The
Create releasestep still emits a non-fatalValidation Failed … already_exists … tag_nameannotation because all three matrix targets race to create the samelatesttag. It is alreadycontinue-on-error: true, so it does not fail the run — left as-is (a proper fix would split release-creation into a single pre-job, out of scope here).🤖 Generated with Claude Code