Remove kissfft

[timosachsenberg]

Summary

• Remove kissfft from the contrib build: drop the KISSFFT build type, archive/SHA256 definitions, source/include dir variables, and the build block from CMakeLists.txt
• Delete libraries.cmake/kissfft.cmake and the injected patches/kissfft/CMakeLists.txt
• Remove the Kiss FFT license text and its entry in Library_Licences.txt; update the Release-only example in AGENTS.md

Notes

• If the main OpenMS repository still references kissfft from contrib, it will need a corresponding cleanup there.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Build & Packaging

  • Removed KISSFFT from the available contribution libraries and build configuration.
  • Removed KISSFFT source, installation, and packaging configuration.

• Licensing

  • Removed KISSFFT licensing references and associated license text.

• Documentation

  • Updated build guidance to use Eigen as the release-only exception example.

[timosachsenberg]

looks good to me. I also checked the OpenMS repo

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ccf10d63-53b9-4770-80c6-08d285e387af

📥 Commits

Reviewing files that changed from the base of the PR and between 26f5adb and 80d4eb8.

📒 Files selected for processing (6)

• AGENTS.md
• CMakeLists.txt
• Library_Licences.txt
• libraries.cmake/kissfft.cmake
• licensetexts/License.bsd.kissfft.txt
• patches/kissfft/CMakeLists.txt

💤 Files with no reviewable changes (4)

• libraries.cmake/kissfft.cmake
• licensetexts/License.bsd.kissfft.txt
• patches/kissfft/CMakeLists.txt
• Library_Licences.txt

---

📝 Walkthrough

Walkthrough

KISSFFT is removed from the contrib CMake configuration, build orchestration, source metadata, license records, and guidance. Its dedicated build configuration and license text are deleted.

Changes

KISSFFT removal

Layer / File(s)	Summary
Remove KISSFFT integration and metadata CMakeLists.txt, libraries.cmake/kissfft.cmake, patches/kissfft/CMakeLists.txt, Library_Licences.txt, licensetexts/License.bsd.kissfft.txt, AGENTS.md	KISSFFT is removed from build selection, source/archive/include configuration, build wiring, dedicated CMake files, licensing records, and the header-only guidance example.

Suggested reviewers: cbielow

Poem

I’m a rabbit with ears held high,
Watching KISSFFT hop goodbye.
CMake paths fade, licenses too,
Clean build lists peek into view.
🐇 One less bundle in the burrow!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing Kiss FFT from the contrib build.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-kissfft

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pjones]

Looks good to me.