Skip to content

RISC-V: fix Inf in nrm2_rvv and use it for RISCV64_ZVL256B #6172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HiderX wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RISC-V: fix Inf in nrm2_rvv and use it for RISCV64_ZVL256B #6172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
513c261
RISC-V: return Inf from nrm2_rvv when the input contains an infinity
HiderX Oct 25, 2026
da4d081
RISC-V: use the RVV NRM2 kernel for RISCV64_ZVL256B
HiderX Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kernel/riscv64/KERNEL.RISCV64_ZVL256B
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ CDOTKERNEL = zdot_vector.c
ZDOTKERNEL = zdot_vector.c
DSDOTKERNEL = ../generic/dot.c

SNRM2KERNEL = nrm2_vector.c
DNRM2KERNEL = nrm2_vector.c
SNRM2KERNEL = nrm2_rvv.c
DNRM2KERNEL = nrm2_rvv.c
CNRM2KERNEL = znrm2_vector.c
ZNRM2KERNEL = znrm2_vector.c

Expand Down
10 changes: 9 additions & 1 deletion kernel/riscv64/nrm2_rvv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,15 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
i += inc_x;
}
}
return(scale * sqrt(ssq));
FLOAT norm = scale * sqrt(ssq);
if (inc_x > 0 && isnan(norm)) {
// An infinite element makes the scaled update compute inf/inf = NaN. The norm is +Inf
// then, unless the input itself contains a NaN.
for (i = 0; i < n; i++)
if (isnan(x[i * inc_x])) return x[i * inc_x];
return INFINITY;
}
return norm;
}