Skip to content

Fix SYMB_ZERO-strided indexing in ?HEAMV/?SYAMV (Reference-LAPACK PR 1394) #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 1 commit into from
Oct 26, 2026
+63 −69
Merged

Fix SYMB_ZERO-strided indexing in ?HEAMV/?SYAMV (Reference-LAPACK PR 1394) #6178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lapack-netlib/SRC/cla_heamv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ mv.f"> */
i__3 = j + i__ * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[j + i__ * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand All @@ -640,7 +640,7 @@ mv.f"> */
i__3 = i__ + j * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[i__ + j * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand Down Expand Up @@ -673,7 +673,7 @@ mv.f"> */
i__3 = i__ + j * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[i__ + j * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand All @@ -686,7 +686,7 @@ mv.f"> */
i__3 = j + i__ * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[j + i__ * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand Down
15 changes: 7 additions & 8 deletions lapack-netlib/SRC/cla_heamv.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
* Online html documentation available at
* http://www.netlib.org/lapack/explore-html/
*
*> \htmlonly
*> Download CLA_HEAMV + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/cla_heamv.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/cla_heamv.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/cla_heamv.f">
*> [TXT]</a>
*> \endhtmlonly
*
* Definition:
* ===========
Expand Down Expand Up @@ -154,7 +152,7 @@
*> \author Univ. of Colorado Denver
*> \author NAG Ltd.
*
*> \ingroup complexHEcomputational
*> \ingroup la_heamv
*
*> \par Further Details:
* =====================
Expand All @@ -175,6 +173,7 @@
* =====================================================================
SUBROUTINE CLA_HEAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
$ INCY )
IMPLICIT NONE
*
* -- LAPACK computational routine --
* -- LAPACK is a software package provided by Univ. of Tennessee, --
Expand Down Expand Up @@ -262,7 +261,7 @@ SUBROUTINE CLA_HEAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
* number of additions in each row.
*
SAFE1 = SLAMCH( 'Safe minimum' )
SAFE1 = (N+1)*SAFE1
SAFE1 = REAL( N+1 )*SAFE1
*
* Form y := alpha*abs(A)*abs(x) + beta*abs(y).
*
Expand Down Expand Up @@ -356,15 +355,15 @@ SUBROUTINE CLA_HEAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
DO J = 1, I
TEMP = CABS1( A( J, I ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
END DO
DO J = I+1, N
TEMP = CABS1( A( I, J ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
Expand Down Expand Up @@ -392,15 +391,15 @@ SUBROUTINE CLA_HEAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
DO J = 1, I
TEMP = CABS1( A( I, J ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
END DO
DO J = I+1, N
TEMP = CABS1( A( J, I ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
Expand Down
8 changes: 4 additions & 4 deletions lapack-netlib/SRC/cla_syamv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ mv.f"> */
i__3 = j + i__ * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[j + i__ * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand All @@ -641,7 +641,7 @@ mv.f"> */
i__3 = i__ + j * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[i__ + j * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand Down Expand Up @@ -674,7 +674,7 @@ mv.f"> */
i__3 = i__ + j * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[i__ + j * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand All @@ -687,7 +687,7 @@ mv.f"> */
i__3 = j + i__ * a_dim1;
temp = (r__1 = a[i__3].r, abs(r__1)) + (r__2 = r_imag(
&a[j + i__ * a_dim1]), abs(r__2));
i__3 = j;
i__3 = jx;
symb_zero__ = symb_zero__ && ((x[i__3].r == 0.f && x[
i__3].i == 0.f) || temp == 0.f);
i__3 = jx;
Expand Down
15 changes: 7 additions & 8 deletions lapack-netlib/SRC/cla_syamv.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
* Online html documentation available at
* http://www.netlib.org/lapack/explore-html/
*
*> \htmlonly
*> Download CLA_SYAMV + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/cla_syamv.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/cla_syamv.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/cla_syamv.f">
*> [TXT]</a>
*> \endhtmlonly
*
* Definition:
* ===========
Expand Down Expand Up @@ -155,7 +153,7 @@
*> \author Univ. of Colorado Denver
*> \author NAG Ltd.
*
*> \ingroup complexSYcomputational
*> \ingroup la_heamv
*
*> \par Further Details:
* =====================
Expand All @@ -176,6 +174,7 @@
* =====================================================================
SUBROUTINE CLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
$ INCY )
IMPLICIT NONE
*
* -- LAPACK computational routine --
* -- LAPACK is a software package provided by Univ. of Tennessee, --
Expand Down Expand Up @@ -264,7 +263,7 @@ SUBROUTINE CLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
* number of additions in each row.
*
SAFE1 = SLAMCH( 'Safe minimum' )
SAFE1 = (N+1)*SAFE1
SAFE1 = REAL( N+1 )*SAFE1
*
* Form y := alpha*abs(A)*abs(x) + beta*abs(y).
*
Expand Down Expand Up @@ -358,15 +357,15 @@ SUBROUTINE CLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
DO J = 1, I
TEMP = CABS1( A( J, I ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
END DO
DO J = I+1, N
TEMP = CABS1( A( I, J ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
Expand Down Expand Up @@ -394,15 +393,15 @@ SUBROUTINE CLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
DO J = 1, I
TEMP = CABS1( A( I, J ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
END DO
DO J = I+1, N
TEMP = CABS1( A( J, I ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*CABS1( X( JX ) )*TEMP
JX = JX + INCX
Expand Down
8 changes: 4 additions & 4 deletions lapack-netlib/SRC/dla_syamv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,15 +578,15 @@ mv.f"> */
i__2 = i__;
for (j = 1; j <= i__2; ++j) {
temp = (d__1 = a[j + i__ * a_dim1], abs(d__1));
symb_zero__ = symb_zero__ && (x[j] == 0. || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0. || temp ==
0.);
y[iy] += *alpha * (d__1 = x[jx], abs(d__1)) * temp;
jx += *incx;
}
i__2 = *n;
for (j = i__ + 1; j <= i__2; ++j) {
temp = (d__1 = a[i__ + j * a_dim1], abs(d__1));
symb_zero__ = symb_zero__ && (x[j] == 0. || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0. || temp ==
0.);
y[iy] += *alpha * (d__1 = x[jx], abs(d__1)) * temp;
jx += *incx;
Expand Down Expand Up @@ -614,15 +614,15 @@ mv.f"> */
i__2 = i__;
for (j = 1; j <= i__2; ++j) {
temp = (d__1 = a[i__ + j * a_dim1], abs(d__1));
symb_zero__ = symb_zero__ && (x[j] == 0. || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0. || temp ==
0.);
y[iy] += *alpha * (d__1 = x[jx], abs(d__1)) * temp;
jx += *incx;
}
i__2 = *n;
for (j = i__ + 1; j <= i__2; ++j) {
temp = (d__1 = a[j + i__ * a_dim1], abs(d__1));
symb_zero__ = symb_zero__ && (x[j] == 0. || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0. || temp ==
0.);
y[iy] += *alpha * (d__1 = x[jx], abs(d__1)) * temp;
jx += *incx;
Expand Down
13 changes: 6 additions & 7 deletions lapack-netlib/SRC/dla_syamv.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
* Online html documentation available at
* http://www.netlib.org/lapack/explore-html/
*
*> \htmlonly
*> Download DLA_SYAMV + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/dla_syamv.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/dla_syamv.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/dla_syamv.f">
*> [TXT]</a>
*> \endhtmlonly
*
* Definition:
* ===========
Expand Down Expand Up @@ -153,7 +151,7 @@
*> \author Univ. of Colorado Denver
*> \author NAG Ltd.
*
*> \ingroup doubleSYcomputational
*> \ingroup la_heamv
*
*> \par Further Details:
* =====================
Expand All @@ -174,6 +172,7 @@
* =====================================================================
SUBROUTINE DLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
$ INCY )
IMPLICIT NONE
*
* -- LAPACK computational routine --
* -- LAPACK is a software package provided by Univ. of Tennessee, --
Expand Down Expand Up @@ -347,15 +346,15 @@ SUBROUTINE DLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
DO J = 1, I
TEMP = ABS( A( J, I ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*ABS( X( JX ) )*TEMP
JX = JX + INCX
END DO
DO J = I+1, N
TEMP = ABS( A( I, J ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*ABS( X( JX ) )*TEMP
JX = JX + INCX
Expand Down Expand Up @@ -383,15 +382,15 @@ SUBROUTINE DLA_SYAMV( UPLO, N, ALPHA, A, LDA, X, INCX, BETA, Y,
DO J = 1, I
TEMP = ABS( A( I, J ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*ABS( X( JX ) )*TEMP
JX = JX + INCX
END DO
DO J = I+1, N
TEMP = ABS( A( J, I ) )
SYMB_ZERO = SYMB_ZERO .AND.
$ ( X( J ) .EQ. ZERO .OR. TEMP .EQ. ZERO )
$ ( X( JX ) .EQ. ZERO .OR. TEMP .EQ. ZERO )

Y( IY ) = Y( IY ) + ALPHA*ABS( X( JX ) )*TEMP
JX = JX + INCX
Expand Down
8 changes: 4 additions & 4 deletions lapack-netlib/SRC/sla_syamv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,15 +823,15 @@ mv.f"> */
i__2 = i__;
for (j = 1; j <= i__2; ++j) {
temp = (r__1 = a[j + i__ * a_dim1], abs(r__1));
symb_zero__ = symb_zero__ && (x[j] == 0.f || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0.f || temp ==
0.f);
y[iy] += *alpha * (r__1 = x[jx], abs(r__1)) * temp;
jx += *incx;
}
i__2 = *n;
for (j = i__ + 1; j <= i__2; ++j) {
temp = (r__1 = a[i__ + j * a_dim1], abs(r__1));
symb_zero__ = symb_zero__ && (x[j] == 0.f || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0.f || temp ==
0.f);
y[iy] += *alpha * (r__1 = x[jx], abs(r__1)) * temp;
jx += *incx;
Expand Down Expand Up @@ -859,15 +859,15 @@ mv.f"> */
i__2 = i__;
for (j = 1; j <= i__2; ++j) {
temp = (r__1 = a[i__ + j * a_dim1], abs(r__1));
symb_zero__ = symb_zero__ && (x[j] == 0.f || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0.f || temp ==
0.f);
y[iy] += *alpha * (r__1 = x[jx], abs(r__1)) * temp;
jx += *incx;
}
i__2 = *n;
for (j = i__ + 1; j <= i__2; ++j) {
temp = (r__1 = a[j + i__ * a_dim1], abs(r__1));
symb_zero__ = symb_zero__ && (x[j] == 0.f || temp ==
symb_zero__ = symb_zero__ && (x[jx] == 0.f || temp ==
0.f);
y[iy] += *alpha * (r__1 = x[jx], abs(r__1)) * temp;
jx += *incx;
Expand Down
Loading
Loading