Repository navigation
fix: handle CRLF line endings in cross-platform submission hashing - #9588
Closed
sslxqii-sudo wants to merge 2 commits into
Closed
sslxqii-sudo wants to merge 2 commits into
sslxqii-sudo wants to merge 2 commits into
Conversation
sslxqii-sudo
changed the title
sslxqii-sudo
changed the title
sslxqii-sudo
changed the title
sslxqii-sudo
changed the title
sslxqii-sudo
changed the title
sslxqii-sudo
changed the title
Author
|
Hi maintainers! The PR title validation is now passing. Could someone with write access please review my changes and approve the PR? Thank you! |
…ically (OpenMined#9551) - Use explicit UTF-8 decoding in _as_sent to handle universal newlines and preserve binary fallback - Sort file entries deterministically by relative POSIX paths in _digest - Pass as_sent=True in _job_has_all_files and _request_has_all_files to match declared hash contract - Add regression tests covering CRLF/LF invariance, path sorting, UTF-8/binary content, and receiver-side checks
…tra files, and disk integrity (OpenMined#9551)
sslxqii-sudo
force-pushed
the
fix-9551-windows-hash
branch
from
October 28, 2026 16:25
bd597b0 to
b6aab68
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OpenMined/PySyft issue #9551 by making submission hashes consistent across Windows and Linux.
Changes
Testing
Related Issue
Closes #9551
Asana Task
Asana task URL: Not provided.
Status
Changes committed and pushed to the fix-9551-windows-hash branch. Linux tests passed. Pull request review and CI status are pending; not merged.