Skip to content

app: fix three e2e flakes at their causes - #44

Merged
aq1018 merged 3 commits into
mainfrom
flakes-91
Oct 14, 2026
Merged

aq1018 merged 3 commits into
mainfrom
flakes-91

Conversation

@aq1018

@aq1018 aq1018 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Three e2e flakes, each pinned by a spec that fails without its fix.

  • About card. It read the identity once, when it appeared, so a descriptor landing later left it on "no layout for ID 1". It now re-reads when the descriptor arrives, as the Stream tab and Live conversions already do.
  • LUT test hook. The sim's writePosLut hook rejected a table written between Connected and the descriptor's arrival. It now waits out the fetch in flight, the way osc lut write has its descriptor before it writes.
  • Mode before goal. pickMode waited on the Mode dropdown, but the goal control follows the servo's read-back of the mode one frame later, so a goal typed sooner went to the old mode's register. pickMode now waits for the goal readout's unit.

Merge with rebase to keep the three commits.

@aq1018
aq1018 merged commit 95d6481 into main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant