Skip to content

table: drop boot_mode from the live commands #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aq1018 merged 1 commit into from
Oct 20, 2026
Merged

table: drop boot_mode from the live commands #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/design/layout-spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Tab contents (map from the descriptor fields already in the file):
- Settings: Identity and bus (id and baud read-only with links "Change on the Servo page ->" / "Change in the connection popover ->"; response_deadline_us editable), Motion limits, Control loops, Safety, Thermal. Motion limits and Safety expanded by default, others collapsed.
- Calibration: one group, all six rows read-only, status strip at top: calibration chip + "Worked out from the values; the servo keeps no date." + "Edit on the Servo page ->". lut_corr shows "55-point table" + "Download .csv" (secondary, small, mock no-op).
- Board: Board constants (shunt, gain, dividers, tick rate, windows, thermistor) read-only, vdd_mv editable; Motor model group (r0, t0, k_r2t, mu, ke, r, recip_ke, b_i, friction) editable, collapsed by default.
- Live values: Status (faults, status flags, clock trim, counters with Clear), Estimates, Raw samples, Commands (editable: torque_enable, mode, goals, the TEL chunks, tel_count, boot_mode, duty, arm/page/chans), Profile/capture (collapsed by default). Read-only groups show grey "updated 0.4 s ago" in the tab header (mock: tick it).
- Live values: Status (faults, status flags, clock trim, counters with Clear), Estimates, Raw samples, Commands (editable: torque_enable, mode, goals, the TEL chunks, tel_count, duty, arm/page/chans), Profile/capture (collapsed by default). Read-only groups show grey "updated 0.4 s ago" in the tab header (mock: tick it).

Row: label bold in column 1 with grey mono register name beneath [intermediate]; tooltip on the register name "addr 0x020, 4 bytes, int32, rw". Value in column 2 mono; read-only values get a tiny grey "ro" tag right of the value. Editable value = value button with pencil on hover -> popover. Save writes immediately; row flashes green.

Expand Down
1 change: 0 additions & 1 deletion src/lib/table-model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ describe("buildTable", () => {
expect(rowOf("tel_drop_count").editable).toBe(true);
expect(placement("torque_enable")).toEqual(["Live values", "Commands"]);
expect(placement("goal_position")).toEqual(["Live values", "Commands"]);
expect(placement("boot_mode")).toEqual(["Live values", "Commands"]);
expect(placement("chans")).toEqual(["Live values", "Commands"]);
expect(placement("pos_lut_cmd")).toEqual(["Live values", "Position table window"]);
expect(placement("pos_lut_state")).toEqual(["Live values", "Position table window"]);
Expand Down
Loading