Repository navigation
web: drop the thermometer flags for the i2t winding estimate - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t_winding_ccis the board NTC plus the rise on the I2t heat,therm_flagskeeps bit 0 (unset) only.thermal.ts; reserved bits are ignored while derating (pinned inthermal.test.ts).th_rise_q016sits under Board constants beside the NTC fields.Bench gate: none, sim covers it (
tests/e2e/winding.spec.ts,src/lib/thermal.test.ts). Merge after open-servo-core #466 (its CI reads the descriptor from main).