Conversation
… fields Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1-Bart-1
reviewed
Sep 26, 2026
1-Bart-1
requested changes
Sep 26, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1-Bort-1
added a commit
that referenced
this pull request
Sep 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 28, 2026
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
KiteModels now requires KiteUtils 0.12.
SysState(kps)uses the newSysState(P)constructor and writes the winch quantities into slot 1 of one-slot vectors. This is the 0.11 → 0.12SysStatemigration that #312 says it is blocked on. #312's frame edits go on top of it, and after that KiteModels can take KiteUtils 0.13.What 0.12 broke
KiteUtils 0.12 gave
SysStatetype parameters for winches, tethers, pulleys, segments and float type. It removedSysState{P}(), and it sizedwinch_force,l_tether,v_reelout,set_force,set_torqueandset_speedby winch/tether count, where they used to be fixed at 4.update_sys_state!assigned 4-element vectors into those fields. On a 0.12SysState(P), with one winch and one tether, that is aDimensionMismatch, and the constructor call before it is aMethodError:That is
test/test-update-sys-state.jlagainst unchangedsrc/, with the compat raised to 0.12. Every testset in the file fails the same way.What changed
src/KiteModels.jl:SysState(length(s.pos)), andss.<field>[1] = ...for the six winch fields. The threeisnothingbranches that wroteNaNbecomesomething(x, NaN), with the same result.test/test-update-sys-state.jl: the nine assertions that compared against[x, 0, 0, 0]now compare against[x]. The value in slot 1 is asserted exactly as before. The three zero slots no longer exist, so there is nothing left to assert about them.Project.toml:KiteUtils = "0.12".docs/Project.tomladds0.12.examples_3d/Project.tomlallowsKiteViewers = "0.5.1, 0.6", because KiteViewers 0.6.0 is the first release that accepts KiteUtils 0.12.src/,test/,examples/ordocs/touches the changed API.SysState(kps),Logger(P, steps),log!,load_loganddemo_state_4pall still work, andLogger's defaults (one winch, one tether,Float32) match whatSysState(kps)builds.The manifests
Pkg.resolve()refuses to lift a package the manifest pins below a new bound (empty intersection between KiteUtils@0.11.13 and project compatibility 0.12). So each.defaultwas seeded from the tracked one and updated only for the packages the bound forces (Pkg.update([...]; preserve=PRESERVE_TIERED)), each under its own Julia (1.11.9, 1.12.7, 1.13.0):examples_3d).CompilerSupportLibraries_jllandOpenSSL_jll, the stdlib JLLs of Julia 1.12.7 against the 1.12.6 that last wrote the file..defaultis theexamplesview thatbin/installcopies into the sub-projects, so it was updated fromexamples/. ItsKiteModelsentry stayspath = "..".Order
KiteUtils = "0.13". It is 29 commits behindmainand conflicts in three places, all mechanical. It was also written before KiteUtils 0.13.0 shipped, and four of its calls are to names that release does not have. With them changed as below, a local merge of Write KA orientations to SysState, keep KS inside the model #312 onto this branch runs the whole Make the KA-frame change load against the KiteUtils 0.13 that shipped KiteViewers.jl#56 suite green against KiteUtils 0.13.0 (the 20 s KPS4test_parking.jlincluded):import KiteUtils: KS, KA, convert_body, convert_orientation→import KiteUtils: fromKS2KA, fromKS2KA_bodyconvert_orientation(calc_orient_quat(s); from=KS, to=KA)→fromKS2KA(calc_orient_quat(s))convert_body(SVec3(0, 0, body_rate); from=KS, to=KA)→fromKS2KA_body(SVec3(0, 0, body_rate))calc_heading(orientation, elevation, azimuth; frame=KS, ...)→calc_heading(fromKS2KA(orientation), elevation, azimuth; ...)main, not Write KA orientations to SysState, keep KS inside the model #312:enu2ned(incalc_orient_quat, three calls) →fromENU2NED, a pure rename in 0.13.Verification
MethodError: no method matching (SysState{11})()in every testset oftest/test-update-sys-state.jlagainst unchangedsrc/test/test-update-sys-state.jlred before, green after: 58/58 on Julia 1.13.0test/test-simulate_4p.jl(theLoggerpath): 2/2 on 1.13.0test/test-kps4.jl: 213 pass, 11 broken, 0 errors on 1.12.7. On 1.13.0,test_find_steady_stateerrors withsolver returned non-finite values— that is find_steady_state! does not converge for KPS4 on Julia 1.13, and CI hides it #314, and this PR does not touchfind_steady_state!. The 11 broken results come from the 4@test_brokenlines already onmain.ss.l_tether[2:4](or similar) from a KiteModelsSysStatenow gets aBoundsError. Those slots were always zero here, so the changelog lists this under Changed, not as breaking.Scope
+56 / -65 across 9 files:
src/KiteModels.jl(−12 net),test/test-update-sys-state.jl(the nine assertions), the three[compat]lines,CHANGELOG.md, and the three.defaultmanifests.Opened by
1-Bort-1, an AI agent working for @1-Bart-1.From OpenSourceAWE/KiteViewers.jl#54 · task
KiteViewers.jl-54