glassbox: guard SWC gate against quantized rhr/temp baselines - #75
Conversation
readiness_composite and overreaching_conjunction both already gate their 0.5*scale worth-mentioning check with dispersionBelowQuantum, since a whole-bpm rhr (or integer skin-temp adc) baseline alternating between two adjacent values has a nonzero MAD that's really rounding noise, not real dispersion. readiness_glassbox does the identical 0.5*scale standardization on the same channels but never got the guard, so crossday_pipeline's rhr/temp inputs could get named as narrative drivers on pure quantization. adds a quantum field to GlassBoxInput (mirrors ReadinessInput.quantum) and uses it in the beyond gate. narrative-only change, doesn't touch the score.
There was a problem hiding this comment.
Sorry @abdulsaheel, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 6 days and 5 hours by commenting @sourcery-ai review. Upgrade to get a review now.
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideThe glass-box readiness narrative now accounts for each input’s measurement quantum before labeling a value as beyond its usual spread, preventing whole-bpm or integer-ADC quantization noise from becoming a narrative driver while preserving scoring behavior. A regression test covers an alternating 58/59 bpm baseline. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
readiness_composite and overreaching_conjunction both gate their 0.5scale worth-mentioning check with dispersionBelowQuantum. readiness_glassbox does the same 0.5scale standardization on the same rhr/temp channels but never got the guard when that fix landed. edge's crossday_pipeline still wires real whole-bpm rhr + integer-adc temp into glassBoxReadiness, so a baseline sitting near a quantization boundary (e.g. alternating 58/59 bpm) could get named a narrative driver off 1-bpm rounding noise.
adds
quantumtoGlassBoxInput(mirrorsReadinessInput.quantum), usesdispersionBelowQuantumto suppress thebeyondUsualSpreadflag when the baseline dispersion doesn't clear the input's own quantization step. narrative-only — doesn't touch the score or drop the input.test added: alternating 58/59 bpm history no longer names rhr as a driver.
Summary by Sourcery
Guard glassbox readiness narratives against baselines whose dispersion does not exceed the input’s measurement quantum.
Bug Fixes:
Enhancements:
Tests: