Match ICD-10 codes regardless of which side has the dot - #21
Open
anapaulagomes wants to merge 1 commit into
Open
anapaulagomes wants to merge 1 commit into
anapaulagomes wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_code_to_regexonly tolerated a missing dot on the value side (definition codeA90matched valueA90.1), never the reverse — a definition code written without the dot (A692, as some community definitions and NSSP/CCDD-style catalogs do) never matched a dotted value (A69.2), and vice versa.A692,A69.2andA69all matchA69.2andA692alike, regardless of which one carries the dot.Test plan
tests/test_filter.py::TestCodeToRegexfor both-direction dot matching, plus a case guarding against unrelated categories still being rejected.A90matchingA900is correct once dot placement is no longer load-bearing).pytest— 240 passed, 15 skipped (pre-existing network-dependent skips).🤖 Generated with Claude Code
https://claude.ai/code/session_01AsB13LEzvKquKxVGwghnoY