Configurable TTL for the targeting cache (default 24 hours) - #45
Merged
mosherBT merged 2 commits intoAug 13, 2026
Merged
Conversation
justadreamer
approved these changes
Jul 31, 2026
mosherBT
reviewed
Aug 11, 2026
Contributor
|
Needs rebase from other PR merges |
- Add cacheTtl parameter and DEFAULT_TARGETING_CACHE_TTL_SECONDS 24h constant. LocalStorage.kt: - Added targetingTimestampKey and targetingCacheTtlMs - Save cache timestamp on every setTargeting - Check if cache expired before returning getTargeting() result - Clear cache timestamp alongside cache in clearTargeting() OptableSDK.kt: - Extended targetingFromCache() KDoc to reflect TTL changes Docs: - Updated README.md with updated cache mechanics Tests: - Added tests for cache expiration - Updated OptableConfigTest.kt
The negative-age guard for a device clock that moved backwards had no coverage, though the iOS SDK tests the equivalent case.
Riabkov
force-pushed
the
feature/configurable-ttl
branch
from
August 12, 2026 11:35
5e0b8b2 to
9a726b6
Compare
mosherBT
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
OptableConfig.kt:
LocalStorage.kt:
OptableSDK.kt:
Docs:
Tests: