Repository navigation
Update to 26.3 - #524
Update to 26.3#524leon-pitzer wants to merge 1 commit into
Conversation
- Updated Minecraft and API versions to 26.3 - Updated the Paper reference to the 26.3 release - Ported Folia Minecraft and Paper patches to 26.3 - Added the region profiler dependency - Updated the README and Maven version to 26.3 - Successfully verified the full Gradle build and test
|
Thanks for working on this. As explained in #220 (comment), we generally handle version updates internally because of the detailed review they require. This PR also introduces a broader command-feedback redesign and drops existing region-threading safeguards; those aren’t appropriate changes to bundle into a version update. Successful compilation and basic startup testing don’t establish that these adaptations are correct. I did incorporate two useful fixes identified here into my local port: owner-thread scheduling for attribute-base reset and passing the correct removal reason to |
Thank you for taking the time to look at my pull request and provide feedback! I had already noticed some of the issues you mentioned, particularly the missing region-threading safeguards and some of the changes to command handling. However, by the time I noticed these issues and realized I had made some mistakes during the porting process, it was already the middle of the night for me. So I decided to leave the fixes for later rather than trying to address them while exhausted. I was already planning to investigate these issues further, fix the mistakes, and perform more extensive testing afterward. I’m fully aware that a successful build and basic startup tests aren’t enough to guarantee stability, especially with Folia’s complex region-threading architecture. I also understand why you prefer to handle version updates internally and why changes unrelated to the version update should be handled separately. I’m glad you were able to incorporate two of the improvements into your own port! Thanks again for your feedback and for taking the time to review my work. |
Updates Folia from Minecraft 26.2 to Minecraft 26.3.
Changes:
mcVersionandapiVersionto 26.3Verification:
./gradlew :folia-server:createPaperclipJar