OfflinePlayer#setWhitelisted writes an empty name to whitelist.json for players obtained via getOfflinePlayer(UUID) #14412

Activity

1. foenichs

   added

   status: needs triage

   on Oct 18, 2026
2. foenichs

   added the

   Bug

   issue type on Oct 18, 2026
3. github-actions

   added

   version: 26.3Game version 26.3Game version 26.3

   on Oct 18, 2026
4. foenichs

   marked this as blocking on Oct 18, 2026

   • Code doesn't add name to whitelist foenichs/Password#5
5. MonoDev-1 commented on Oct 19, 2026

   

   MonoDev-1

   on Oct 19, 2026

   More actions

   @Override
       public OfflinePlayer getOfflinePlayer(UUID id) {
           Preconditions.checkArgument(id != null, "UUID id cannot be null");
   
           OfflinePlayer result = this.getPlayer(id);
           if (result == null) {
               result = this.offlinePlayers.get(id);
               if (result == null) {
                   result = new CraftOfflinePlayer(this, new NameAndId(id, ""));
                   this.offlinePlayers.put(id, result);
               }
           } else {
               this.offlinePlayers.remove(id);
           }
   
           return result;
       }

   I believe the bug comes from this line: result = new CraftOfflinePlayer(this, new NameAndId(id, "")); which gives the offline player an empty name and setting whitelisted to true forwards the NameAndId to UserWhiteListEntry and gets serialized with the empty name.

   👍React with 👍1Reacted by foenichs
6. electronicboy commented on Oct 20, 2026

   

   electronicboy

   on Oct 20, 2026

   Member

   More actions

   The logic doesn't do a lookup for offline players from the UUID, and so we just don't have a name to populate, and there isn't much interest in making this API have to check mojangs API for a name on usage; ideally that API would support working with player profiles and let the caller deal with that, but I think that ship has sailed

   👍React with 👍1Reacted by MonoDev